fix(web): prevent provider model submenu overlap#1403
Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom Mar 25, 2026
Merged
fix(web): prevent provider model submenu overlap#1403juliusmarminge merged 1 commit intopingdotgg:mainfrom
juliusmarminge merged 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:XS
emrezeytin
pushed a commit
to emrezeytin/t3code
that referenced
this pull request
Mar 25, 2026
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 26, 2026
Port upstream sideOffset={4} fix and submenu gap test to fork's
multi-provider picker structure.
Merged
7 tasks
kkorenn
pushed a commit
to kkorenn/k1code
that referenced
this pull request
Mar 26, 2026
apexsloth
pushed a commit
to apexslothforks/t3code
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
The provider/model selector could render its nested submenu on top of the parent menu, which made the control look visually broken and harder to scan.
This keeps the change small and targeted to submenu positioning only.
Fixes #1401
UI Changes
Before:
After:
Hover interaction
Checklist
Note
Fix provider model submenu overlap by adding a side offset gap
Adds
sideOffset={4}to theMenuSubPopupin ProviderModelPicker.tsx so the submenu renders with a visible horizontal gap from the parent menu instead of overlapping it. A browser test is added to assert the submenu's left edge is at least 2px to the right of the trigger's right edge.Macroscope summarized 2530b6a.