fix(web): avoid false draft attachment persistence warnings#1153
Merged
juliusmarminge merged 4 commits intopingdotgg:mainfrom Mar 24, 2026
Merged
fix(web): avoid false draft attachment persistence warnings#1153juliusmarminge merged 4 commits intopingdotgg:mainfrom
juliusmarminge merged 4 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:L
shivamhwp
force-pushed
the
attachment-bug
branch
from
c69a429 to
5aa4f85
Compare
Flush pending composer draft writes before verifying persisted attachments so image drafts are not incorrectly marked as unsaved due to the debounce window. Made-with: Cursor
shivamhwp
force-pushed
the
attachment-bug
branch
from
5aa4f85 to
54935e5
Compare
juliusmarminge
approved these changes
Mar 24, 2026
Chrono-byte
pushed a commit
to Chrono-byte/t3code
that referenced
this pull request
Mar 24, 2026
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 24, 2026
4 tasks
sfncore
pushed a commit
to sfncore/t3code
that referenced
this pull request
Mar 24, 2026
…draft threads, settings refactor Merges 18 upstream commits including: - feat: terminal toggle button in chat header (pingdotgg#633) - feat: resizable chat sidebar (pingdotgg#1347) - feat: stream git hook progress events (pingdotgg#1214) - feat: configurable base directory (pingdotgg#826) - feat: persist model options (pingdotgg#1121) - refactor: simplify settings layout (pingdotgg#1288) - refactor: flatten Git service layer (pingdotgg#1255) - fix: draft-thread project scripts (pingdotgg#1178) - fix: draft attachment persistence warnings (pingdotgg#1153) - fix: PTY adapter runtime loading (pingdotgg#1311) - fix: Claude SDK filesystem settings (pingdotgg#1334) - Various UI fixes and polish Co-Authored-By: Claude Opus 4.6 <[email protected]>
ranvier2d2
added a commit
to Ranvier-Technologies/t3code-OTP
that referenced
this pull request
Mar 24, 2026
Cherry-picked from pingdotgg/t3code: - 843d6d8 fix: add license field to npm package (pingdotgg#1272) - e11fb6e fix(web): avoid false draft attachment persistence warnings (pingdotgg#1153) - 2b08d86 Add resizable chat sidebar (pingdotgg#1347) - e823f8f ci(github): exclude test files from mixed PR size calculation (pingdotgg#1105) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
3 tasks
ranvier2d2
added a commit
to Ranvier-Technologies/t3code-OTP
that referenced
this pull request
Mar 24, 2026
Cherry-picked from pingdotgg/t3code: - 843d6d8 fix: add license field to npm package (pingdotgg#1272) - e11fb6e fix(web): avoid false draft attachment persistence warnings (pingdotgg#1153) - 2b08d86 Add resizable chat sidebar (pingdotgg#1347) - e823f8f ci(github): exclude test files from mixed PR size calculation (pingdotgg#1105) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
gabrielMalonso
pushed a commit
to gabrielMalonso/t3code
that referenced
this pull request
Mar 24, 2026
4 tasks
apexsloth
pushed a commit
to apexslothforks/t3code
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #979
Before
After
Why
The composer draft store debounces
localStoragewrites, but attachment verification was reading storage immediately in a microtask. That could race the pending write and incorrectly flag persisted attachments as non-persisted, which surfaced the "Draft attachment could not be saved locally" warning even when persistence would have succeeded.Test plan
bun fmtbun lintbun typecheckUI evidence
Made with Cursor
Note
[!NOTE]
Fix false draft attachment persistence warnings in composer draft store
verifyPersistedAttachmentshelper in composerDraftStore.ts that flushes pending debounced storage writes before reading persisted attachment IDs, preventing race conditions where attachments appeared unpersisted.nonPersistedImageIdsis empty after the debounced write is flushed.Macroscope summarized a86d562.