Skip to content

fix(server): close stdin for noninteractive process runs #10583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashranaway wants to merge 1 commit into from
Closed

fix(server): close stdin for noninteractive process runs #10583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/server/src/processRunner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { TestClock } from "effect/testing";
import { ChildProcessSpawner } from "effect/unstable/process";
import { HostProcessEnvironment, HostProcessPlatform } from "@t3tools/shared/hostProcess";
import { SpawnExecutableResolution } from "@t3tools/shared/shell";
import * as NodeServices from "@effect/platform-node/NodeServices";

import * as ProcessRunner from "./processRunner.ts";

Expand Down Expand Up @@ -80,6 +81,28 @@ const runWith =
);

describe("runProcess", () => {
for (const stdin of [undefined, "", "hello\n世界\n"]) {
it.effect(
`delivers EOF to a real child with ${stdin === undefined ? "omitted" : stdin === "" ? "empty" : "provided"} stdin`,
() =>
Effect.gen(function* () {
const runner = yield* ProcessRunner.ProcessRunner;
const result = yield* runner.run({
command: process.execPath,
args: [
"-e",
"process.stdin.setEncoding('utf8'); let input = ''; process.stdin.on('data', chunk => { input += chunk }); process.stdin.on('end', () => { process.stdout.write('EOF:' + input) });",
],
...(stdin !== undefined ? { stdin } : {}),
});
expect(result.code).toBe(0);
expect(result.stdout).toBe(`EOF:${stdin ?? ""}`);
expect(result.timedOut).toBe(false);
}).pipe(Effect.provide(ProcessRunner.layer.pipe(Layer.provide(NodeServices.layer)))),
10_000,
);
}

it.effect("collects stdout through an injected ChildProcessSpawner", () =>
Effect.gen(function* () {
const spawner = makeSpawner((command) =>
Expand Down
3 changes: 3 additions & 0 deletions apps/server/src/processRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ const runProcessCore = Effect.fn("processRunner.runProcessCore")(function* (
}
: {}),
shell: spawnCommand.shell,
// This runner has no interactive input channel. An unused pipe would
// leave commands waiting for stdin until the process timeout.
stdin: input.stdin === undefined ? "ignore" : "pipe",
}),
)
.pipe(
Expand Down
Loading