Skip to content

PR section shows “Approved” before the required number of approvals is reached #25717

Closed

Description

@migueel15

When a repository requires two approvals to merge a pull request, T3 Code shows it in the “Approved” section after receiving only one. This can suggest that the PR meets its review requirements even though another approval is still needed.

Steps to reproduce:

  1. Configure a branch to require two approvals before merging.
  2. Create a pull request and link it to a T3 Code thread.
  3. Obtain one approval.
  4. Check the PR section in T3 Code.

Actual behavior: The PR appears as “Approved” with only one approval.

Expected behavior: T3 Code should indicate that more approvals are needed, for example by showing “1 of 2 approvals” or an equivalent status. When the necessary information is unavailable, it should avoid implying that all review requirements have been met.

Scope: Improve how required review information is displayed. Other merge requirements, such as checks or the merge queue, are outside the scope of this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions