Repository navigation
Replies: 1 comment
|
Thanks — this is a real gap on top of #12651 / #12652, and the code matches the proposal. Not a duplicate. #12651 is the fallback choosing the wrong slug. #12652 only changes what the Claude CLI error says. Neither names the attempted model or points at Settings. #5359 is the silent title/branch half of the same family. What happens todayCommit / PR generation already reaches the client: That error type is only
Title / branch generation still only What already exists for the Settings jump
Suggested shape
Smaller useful slice if we split it: always name the attempted model + Settings button, then add the "this was a fallback" origin once the resolver exposes it. Accepting as a QoL enhancement. No extra info needed. Keep #12651 (fallback slug) and #12652 (CLI detail) separate — this is presentation only. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Context
#12651 confirmed that one-shot text generation (commit messages, PR content, branch names, thread titles) can fail opaquely: the Commit popup showed an unrelated stderr notice while the real cause was an unconfigured/unsupported text-generation model. #12652 improves what the error says (it now surfaces the CLI's own stdout error), but the popup still leaves the user to figure out where the fix lives.
Proposal
When one-shot text generation fails, make the error actionable by surfacing what the server already knows and offering the fix in place:
textGenerationModelSelectionis unset and a fallback was used, say so explicitly: "No text generation model was configured, so the provider default (claude-haiku-4-5) was used." That is server-known information —resolveTextGenerationProvider()knows whether it fell back and to which slug.Why
The failure mode in #12651 would have been a two-click self-fix from the Commit dialog itself: popup names the fallback model → button opens Settings → user picks a model their backend allows. Instead it took a full diagnostic session (captured spawns, extracted bundle source) to discover that
textGenerationModelSelectionwas unset and that the fallback slug was being rejected by the backend.The information needed for this already exists at the failure site; this is purely about presenting it.
Impact
Quality-of-life enhancement on top of the #12651 fixes.
Note
🤖 GLM 5.3 Flash on behalf of iliasgws
All reactions