Repository navigation
Comparing changes
Open a pull request
base repository: pingdotgg/t3code
base: main
head repository: pingdotgg/t3code
compare: fix/issue-28141
- 13 commits
- 3 files changed
- 2 contributors
Commits on Oct 31, 2026
-
test(server): reproduce #28141, navigate cannot leave a page whose sc…
…ript never yields An agent's preview_navigate on a tab whose page script never yields does not land on the new page: with readiness "load" it times out, and with readiness "none" the navigation never commits. The fake renderer models a busy main thread that Chromium stops on Runtime.terminateExecution. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c199da4 - Browse repository at this point
Copy the full SHA c199da4View commit details -
fix(server): preview navigation leaves a page whose script never yields
A same-site navigation shares the renderer, so a page script that never yields kept the old document: navigate timed out with readiness "load" and never committed with "none". Before an agent navigate or a viewer address bar, back/forward, reload or hard reload, probe the page with a trivial Runtime.evaluate and send Runtime.terminateExecution only if it does not answer within 1s. Terminating unconditionally would hit the next script on an idle renderer, possibly the new page's first one. The probe shares evaluate's race-and-terminate, and spends the navigate's own timeout. Fixes #28141 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 38b5a44 - Browse repository at this point
Copy the full SHA 38b5a44View commit details -
fix(server): bound the navigation probe by its timeout and cover view…
…er navigation The busy-script probe now waits at most the navigation's own timeout, so a short timeoutMs is not delayed by the probe's 1s bound. Viewer navigate, back, forward and reload are covered by a test on a page whose script never yields. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0125747 - Browse repository at this point
Copy the full SHA 0125747View commit details -
test(server): a busy-script probe spends the navigation's own budget
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46467f2 - Browse repository at this point
Copy the full SHA 46467f2View commit details -
test(server): type the fake goto's options
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f054e85 - Browse repository at this point
Copy the full SHA f054e85View commit details
Commits on Nov 10, 2026
-
Merge remote-tracking branch 'origin/main' into fix/issue-28141
# Conflicts: # apps/server/src/preview/ServerBrowser.test.ts # apps/server/src/preview/ServerBrowserPage.ts
Configuration menu - View commit details
-
Copy full SHA for 5478acb - Browse repository at this point
Copy the full SHA 5478acbView commit details -
style(server): format the navigation script probe
AI-assisted; verified with the tests and tools listed above.
Configuration menu - View commit details
-
Copy full SHA for 56f4f77 - Browse repository at this point
Copy the full SHA 56f4f77View commit details
Commits on Nov 11, 2026
-
Configuration menu - View commit details
-
Copy full SHA for de4782d - Browse repository at this point
Copy the full SHA de4782dView commit details -
test(server): drop the duplicate goForward probe case
goBack and goForward share one code path. AI-assisted; verified with the tests and tools listed above.
Configuration menu - View commit details
-
Copy full SHA for 71d0959 - Browse repository at this point
Copy the full SHA 71d0959View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe842fb - Browse repository at this point
Copy the full SHA fe842fbView commit details
Commits on Nov 12, 2026
-
Merge remote-tracking branch 'origin/main' into fix/issue-28141
# Conflicts: # apps/server/src/preview/ServerBrowser.test.ts
Configuration menu - View commit details
-
Copy full SHA for dda7a4d - Browse repository at this point
Copy the full SHA dda7a4dView commit details -
fix(server): the navigation probe leaves goto half its budget
An unanswered probe could spend the whole budget when it was 1s or less, leaving goto 1 ms. A cross-site navigation, which leaves a hung page by itself, then failed where main succeeded. AI-assisted; verified with the tests and tools listed above. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1678414 - Browse repository at this point
Copy the full SHA 1678414View commit details -
fix(server): agent navigation probes alongside goto, not before it
Probing before goto took time from a cross-site navigation that would otherwise have left the hung page in a new renderer, so it could miss a deadline that main met. goto now starts at once with the caller's full timeout, and the probe runs alongside it to stop a hung same-site script. AI-assisted; verified with the tests and tools listed above. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4061c4a - Browse repository at this point
Copy the full SHA 4061c4aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...fix/issue-28141