Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pingdotgg/t3code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: pingdotgg/t3code
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix/issue-28141
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 3 files changed
  • 2 contributors

Commits on Oct 31, 2026

  1. test(server): reproduce #28141, navigate cannot leave a page whose sc…

    …ript never yields
    
    An agent's preview_navigate on a tab whose page script never yields does
    not land on the new page: with readiness "load" it times out, and with
    readiness "none" the navigation never commits. The fake renderer models a
    busy main thread that Chromium stops on Runtime.terminateExecution.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 31, 2026
    Configuration menu
    Copy the full SHA
    c199da4 View commit details
    Browse the repository at this point in the history
  2. fix(server): preview navigation leaves a page whose script never yields

    A same-site navigation shares the renderer, so a page script that never
    yields kept the old document: navigate timed out with readiness "load" and
    never committed with "none". Before an agent navigate or a viewer address
    bar, back/forward, reload or hard reload, probe the page with a trivial
    Runtime.evaluate and send Runtime.terminateExecution only if it does not
    answer within 1s. Terminating unconditionally would hit the next script on
    an idle renderer, possibly the new page's first one. The probe shares
    evaluate's race-and-terminate, and spends the navigate's own timeout.
    
    Fixes #28141
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 31, 2026
    Configuration menu
    Copy the full SHA
    38b5a44 View commit details
    Browse the repository at this point in the history
  3. fix(server): bound the navigation probe by its timeout and cover view…

    …er navigation
    
    The busy-script probe now waits at most the navigation's own timeout, so a
    short timeoutMs is not delayed by the probe's 1s bound. Viewer navigate,
    back, forward and reload are covered by a test on a page whose script never
    yields.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 31, 2026
    Configuration menu
    Copy the full SHA
    0125747 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    46467f2 View commit details
    Browse the repository at this point in the history
  5. test(server): type the fake goto's options

    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 31, 2026
    Configuration menu
    Copy the full SHA
    f054e85 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2026

  1. Merge remote-tracking branch 'origin/main' into fix/issue-28141

    # Conflicts:
    #	apps/server/src/preview/ServerBrowser.test.ts
    #	apps/server/src/preview/ServerBrowserPage.ts
    juliusmarminge committed Nov 10, 2026
    Configuration menu
    Copy the full SHA
    5478acb View commit details
    Browse the repository at this point in the history
  2. style(server): format the navigation script probe

    AI-assisted; verified with the tests and tools listed above.
    juliusmarminge committed Nov 10, 2026
    Configuration menu
    Copy the full SHA
    56f4f77 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2026

  1. Configuration menu
    Copy the full SHA
    de4782d View commit details
    Browse the repository at this point in the history
  2. test(server): drop the duplicate goForward probe case

    goBack and goForward share one code path.
    
    AI-assisted; verified with the tests and tools listed above.
    juliusmarminge committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    71d0959 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fe842fb View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2026

  1. Merge remote-tracking branch 'origin/main' into fix/issue-28141

    # Conflicts:
    #	apps/server/src/preview/ServerBrowser.test.ts
    juliusmarminge committed Nov 12, 2026
    Configuration menu
    Copy the full SHA
    dda7a4d View commit details
    Browse the repository at this point in the history
  2. fix(server): the navigation probe leaves goto half its budget

    An unanswered probe could spend the whole budget when it was 1s or less,
    leaving goto 1 ms. A cross-site navigation, which leaves a hung page by
    itself, then failed where main succeeded.
    
    AI-assisted; verified with the tests and tools listed above.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Nov 12, 2026
    Configuration menu
    Copy the full SHA
    1678414 View commit details
    Browse the repository at this point in the history
  3. fix(server): agent navigation probes alongside goto, not before it

    Probing before goto took time from a cross-site navigation that would
    otherwise have left the hung page in a new renderer, so it could miss a
    deadline that main met. goto now starts at once with the caller's full
    timeout, and the probe runs alongside it to stop a hung same-site script.
    
    AI-assisted; verified with the tests and tools listed above.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Nov 12, 2026
    Configuration menu
    Copy the full SHA
    4061c4a View commit details
    Browse the repository at this point in the history
Loading