Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pingdotgg/t3code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: pingdotgg/t3code
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix/issue-24667
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 5 files changed
  • 2 contributors

Commits on Oct 25, 2026

  1. test(server): agent-sent skill mentions must not invoke skills (#24667)

    Failing tests: ThreadManagementService.sendToThread passes an agent's
    cross-thread message (senderThreadId set) through unchanged, so a $, €,
    or other currency-sign mention, or a leading /name, still reaches Claude
    and Codex as a native skill invocation on both the start and steer paths.
    A user-origin message keeps its skill dispatch.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 25, 2026
    Configuration menu
    Copy the full SHA
    c14360c View commit details
    Browse the repository at this point in the history
  2. fix(server): agent-sent messages no longer invoke the recipient's ski…

    …lls (#24667)
    
    ThreadManagementService.sendToThread passed another agent's message
    through unchanged, so a currency-sign mention or a leading /name reached
    Claude and Codex as a native skill invocation. When senderThreadId is
    set, a word joiner now follows a currency sign before a name and a
    leading slash, the same break webhook prompts use. User, scheduled,
    launch, and delegation prompts are untouched.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 25, 2026
    Configuration menu
    Copy the full SHA
    e31d5f1 View commit details
    Browse the repository at this point in the history
  3. fix(server): agent-sent skill breaks leave shell vars, amounts, and p…

    …aths intact (#24667)
    
    The word-joiner break followed every currency sign before a letter or
    digit and any leading slash, so an agent's quoted "$HOME", $20 budgets,
    and /tmp/report.txt paths reached the recipient altered. It now breaks
    only tokens the shared SKILL_MENTION_PATTERN accepts, and a leading
    slash only when a single /name token follows.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 25, 2026
    Configuration menu
    Copy the full SHA
    6f264fc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4d6338f View commit details
    Browse the repository at this point in the history
  5. fix(server): agent-sent Codex skill mentions inside punctuation no lo…

    …nger invoke skills (#24667)
    
    Codex reads `$name` with no surrounding whitespace, as in `($name)`,
    `$name.`, or `[$name](path)`, but the agent-message break only covered
    whitespace-bounded mention tokens. sendToThread now also breaks `$name`
    wherever name is one of the recipient instance's known skills, read from
    the ProviderRegistry snapshot the composers already use. Other `$` tokens
    such as quoted shell variables stay byte-identical.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 25, 2026
    Configuration menu
    Copy the full SHA
    10af334 View commit details
    Browse the repository at this point in the history
  6. fix(server): agent-sent skill breaks only touch the recipient's known…

    … skill names (#24667)
    
    The whitespace-bounded mention pass broke every `$TOKEN`, so unquoted
    shell variables like `$BUILD_DIR` and `$HOME` gained a word joiner
    whenever an agent sent them. That pass now applies the same
    recipient-skill-name guard as the punctuation pass.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Oct 25, 2026
    Configuration menu
    Copy the full SHA
    33bc6f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2026

  1. Merge remote-tracking branch 'origin/main' into fix/issue-24667

    # Conflicts:
    #	apps/server/src/orchestration-v2/ThreadManagementService.test.ts
    #	apps/server/src/orchestration-v2/ThreadManagementService.ts
    juliusmarminge committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    3b1c021 View commit details
    Browse the repository at this point in the history
  2. test(server): drop duplicate agent skill-break cases

    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    323a91a View commit details
    Browse the repository at this point in the history
  3. fix(server): agent skill breaks no longer depend on the registry or t…

    …ouch leading paths
    
    Break every skill-shaped mention (a currency sigil followed by a lowercase
    letter) instead of only names the provider registry happens to know, so
    project skills in unscanned worktrees are covered. Put the word joiner
    before a leading /word instead of inside it, so a path like /tmp keeps
    its bytes.
    
    AI-assisted; verified with the tests and tools listed above.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    38de69c View commit details
    Browse the repository at this point in the history
  4. fix(server): decide agent skill breaks in the adapters from the real …

    …skill list
    
    The service-level rewrite had to guess skill names: the registry missed
    project skills, and breaking every lowercase sigil corrupted shell
    variables and filenames such as $result or posts.$postId.tsx. The
    Claude and Codex adapters already see the message's sender and the
    thread's real skills at dispatch, so neutralize there and only for
    names that are skills:
    
    - Claude skips T3 skill dispatch for another agent's text and puts a
      word joiner before a leading /name only when name is a real skill.
    - Codex keeps an agent's text as sent, breaking only $name mentions of
      skills from skills/list for the session cwd (all $name if that list
      cannot be read).
    
    ThreadManagementService forwards the text unchanged again.
    
    AI-assisted; verified with the tests and tools listed above.
    
    Co-Authored-By: Claude Opus 5.5 <[email protected]>
    juliusmarminge and claude committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    bb01f78 View commit details
    Browse the repository at this point in the history
Loading