Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pingdotgg/t3code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: pingdotgg/t3code
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: factory/issue-34435
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 3 files changed
  • 1 contributor

Commits on Nov 11, 2026

  1. test(server): launcher protocol preflight gives Windows hosts Windows… 

    … steps

Fails on main: the blocked-update reason always names curl | sh, which -a and
~/.local/bin/t3 service install, none of which apply on Windows (#34435).

AI-assisted; verified with the tests and tools listed above.
    @juliusmarminge
    juliusmarminge committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    6e2059e View commit details
    Browse the repository at this point in the history

  2. fix(server): give Windows hosts Windows steps when an old service lau… 

    …ncher blocks an update

A remote update blocked by an old launcher protocol always told the host to run
`curl | sh`, `which -a t3` and `~/.local/bin/t3 service install`, none of which
work on Windows, where `t3 service install` does not exist. The preflight now
takes the host platform from HostProcess.Platform and, on Windows, names the
PowerShell installer pinned to the target version, `where.exe`, the `t3.cmd`
path to start the launcher from, and that remote updates never move a Windows
launcher, so the swap repeats on each launcher protocol bump.

Fixes #34435

AI-assisted; verified with the tests and tools listed above.
    @juliusmarminge
    juliusmarminge committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    9a197b2 View commit details
    Browse the repository at this point in the history

  3. fix(server): service launcher repoints the Windows t3.cmd after a rem… 

    …ote update

On Linux and macOS a committed remote update repoints the systemd unit or
launchd plist, so the launcher restarts on the new runtime. Windows has no
unit, so a Windows launcher stayed on the version that first started it and
every launcher protocol bump blocked remote updates again. With no service
unit, the launcher now moves recorded installer t3.cmd shims (exactly as the
install script writes them, into this home's runtime) forward to the committed
version, never backwards. The Windows preflight text no longer says to repeat
the manual swap on each protocol bump.

Fixes #34435

AI-assisted; verified with the tests and tools listed above.
    @juliusmarminge
    juliusmarminge committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    b45926d View commit details
    Browse the repository at this point in the history

  4. fix(server): Windows launcher recovery selects the installed runtime 

    Following the Windows steps left service-state.json selecting the old server:
install.ps1 installs the runtime and rewrites t3.cmd but does not touch the
service selection, so the new launcher started the old server with a context
it rejects. The steps now stop the launcher and write a service state that
selects the installed version with no update record before starting it again.

This also drops the launcher's t3.cmd repoint: local shim writers take no lock
it could share, so a concurrent install or `t3 update` could be downgraded.
The message says plainly that the manual swap repeats on each launcher
protocol change until Windows has a service installer.

Fixes #34435

AI-assisted; verified with the tests and tools listed above.
    @juliusmarminge
    juliusmarminge committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    6ea69c9 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into factory/issue-34435

    @juliusmarminge
    juliusmarminge committed Nov 11, 2026
    Configuration menu
    Copy the full SHA
    a449612 View commit details
    Browse the repository at this point in the history
Loading