Skip to content

Commit ff4f108

Browse files
paul-vdclaude
andcommitted
fix(mobile): show a real settings cog in the Android sidebar header
The Android sidebar settings button drew itself with a custom native view: a circle with eight radiating spokes, hardcoded grey, sized 44x44 — a sun, not a cog, matching neither the filter button's icon set nor its tint or capsule chrome. Dropped the Android override so both platforms use the shared SidebarHeaderActions, which maps gearshape to the settings cog and reuses SidebarFilterButton's chrome. The bespoke native button had no remaining consumer on either platform, so it goes too. Co-authored-by: Claude Opus 5 <[email protected]>
1 parent 1b16ed6 commit ff4f108

6 files changed

Lines changed: 0 additions & 223 deletions

File tree

‎apps/mobile/modules/t3-native-controls/android/src/main/java/expo/modules/t3nativecontrols/T3HeaderButtonView.kt‎

Lines changed: 0 additions & 97 deletions
This file was deleted.

‎apps/mobile/modules/t3-native-controls/android/src/main/java/expo/modules/t3nativecontrols/T3NativeControlsModule.kt‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,5 @@ class T3NativeControlsModule : Module() {
3232
?.resolve("t3-showcase-ready")
3333
?.writeText(scene)
3434
}
35-
36-
View(T3HeaderButtonView::class) {
37-
Prop("label") { view: T3HeaderButtonView, label: String ->
38-
view.setLabel(label)
39-
}
40-
Prop("systemImage") { view: T3HeaderButtonView, systemImage: String ->
41-
view.setSystemImage(systemImage)
42-
}
43-
44-
Events("onTriggered")
45-
}
4635
}
4736
}

‎apps/mobile/modules/t3-native-controls/ios/T3HeaderButtonView.swift‎

Lines changed: 0 additions & 62 deletions
This file was deleted.

‎apps/mobile/modules/t3-native-controls/ios/T3NativeControlsModule.swift‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -87,16 +87,5 @@ public final class T3NativeControlsModule: Module {
8787
let readyPath = NSHomeDirectory() + "/Library/Caches/T3ShowcaseReadyScene"
8888
try? scene.write(toFile: readyPath, atomically: true, encoding: .utf8)
8989
}
90-
91-
View(T3HeaderButtonView.self) {
92-
Prop("label") { (view: T3HeaderButtonView, label: String) in
93-
view.setLabel(label)
94-
}
95-
Prop("systemImage") { (view: T3HeaderButtonView, systemImage: String) in
96-
view.setSystemImage(systemImage)
97-
}
98-
99-
Events("onTriggered")
100-
}
10190
}
10291
}

‎apps/mobile/src/features/threads/sidebar-header-actions.android.tsx‎

Lines changed: 0 additions & 16 deletions
This file was deleted.

‎apps/mobile/src/native/T3HeaderButton.android.tsx‎

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)