Skip to content

Commit fec6318

Browse files
Use Effect HTTP server in observability trace test
1 parent 8cf8ffd commit fec6318

1 file changed

Lines changed: 49 additions & 82 deletions

File tree

Lines changed: 49 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -1,89 +1,67 @@
1+
import * as NodeHttpServer from "@effect/platform-node/NodeHttpServer";
2+
import { expect, it } from "@effect/vitest";
3+
import * as Deferred from "effect/Deferred";
14
import * as Effect from "effect/Effect";
2-
import * as Layer from "effect/Layer";
3-
import * as ManagedRuntime from "effect/ManagedRuntime";
45
import * as Redacted from "effect/Redacted";
5-
import { FetchHttpClient } from "effect/unstable/http";
6+
import * as Schema from "effect/Schema";
7+
import * as HttpServer from "effect/unstable/http/HttpServer";
8+
import * as HttpServerRequest from "effect/unstable/http/HttpServerRequest";
9+
import * as HttpServerResponse from "effect/unstable/http/HttpServerResponse";
610
import type { OtlpTracer } from "effect/unstable/observability";
7-
import { expect, it } from "vite-plus/test";
811

912
import { EnvironmentMintRequestFailed } from "./environments/EnvironmentConnector.ts";
1013
import { makeRelayTraceLayer } from "./observability.ts";
1114

15+
interface ExportedRequest {
16+
readonly authorization: string | undefined;
17+
readonly body: string;
18+
readonly dataset: string | undefined;
19+
}
20+
1221
const otlpAttributeValue = (value: {
1322
readonly stringValue?: string | null;
1423
readonly boolValue?: boolean | null;
1524
readonly intValue?: number | null;
1625
readonly doubleValue?: number | null;
1726
}) => value.stringValue ?? value.boolValue ?? value.intValue ?? value.doubleValue;
1827

19-
it("exports schema error fields as span attributes", async () => {
20-
const NodeHttp = await import("node:http");
21-
let resolveRequest:
22-
| ((request: {
23-
readonly body: string;
24-
readonly headers: Record<string, string | ReadonlyArray<string> | undefined>;
25-
}) => void)
26-
| undefined;
27-
const firstRequest = new Promise<{
28-
readonly body: string;
29-
readonly headers: Record<string, string | ReadonlyArray<string> | undefined>;
30-
}>((resolve) => {
31-
resolveRequest = resolve;
32-
});
33-
const server = NodeHttp.createServer((request, response) => {
34-
const chunks: Buffer[] = [];
35-
request.on("data", (chunk) => {
36-
chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk));
37-
});
38-
request.on("end", () => {
39-
resolveRequest?.({
40-
body: Buffer.concat(chunks).toString("utf8"),
41-
headers: request.headers,
42-
});
43-
resolveRequest = undefined;
44-
response.statusCode = 204;
45-
response.end();
46-
});
47-
});
48-
49-
await new Promise<void>((resolve, reject) => {
50-
server.once("error", reject);
51-
server.listen(0, "127.0.0.1", resolve);
52-
});
53-
const address = server.address();
54-
if (!address || typeof address === "string") {
55-
throw new Error("Expected TCP collector address");
56-
}
57-
58-
const runtime = ManagedRuntime.make(
59-
makeRelayTraceLayer({
60-
tracesEndpoint: `http://127.0.0.1:${address.port}/v1/traces`,
61-
tracesDatasetName: "relay-test-traces",
62-
ingestToken: Redacted.make("test-token"),
63-
}).pipe(Layer.provide(FetchHttpClient.layer)),
64-
);
28+
const decodeJson = Schema.decodeUnknownEffect(Schema.UnknownFromJsonString);
6529

66-
try {
67-
await runtime.runPromise(
68-
Effect.fail(
69-
new EnvironmentMintRequestFailed({
70-
environmentId: "environment-1",
71-
operation: "connect",
72-
cause: new Error("upstream unavailable"),
73-
}),
74-
).pipe(Effect.withSpan("relay.test.schema_error"), Effect.exit),
30+
it.effect("exports schema error fields as span attributes", () =>
31+
Effect.gen(function* () {
32+
const exportedRequest = yield* Deferred.make<ExportedRequest>();
33+
yield* HttpServer.serveEffect(
34+
Effect.gen(function* () {
35+
const request = yield* HttpServerRequest.HttpServerRequest;
36+
yield* Deferred.succeed(exportedRequest, {
37+
authorization: request.headers.authorization,
38+
body: yield* request.text,
39+
dataset: request.headers["x-axiom-dataset"],
40+
});
41+
return HttpServerResponse.empty({ status: 204 });
42+
}),
7543
);
76-
await runtime.dispose();
7744

78-
const request = await Effect.runPromise(
79-
Effect.raceFirst(
80-
Effect.promise(() => firstRequest),
81-
Effect.sleep("1 second").pipe(
82-
Effect.andThen(Effect.die(new Error("Timed out waiting for OTLP trace export"))),
83-
),
45+
yield* Effect.fail(
46+
new EnvironmentMintRequestFailed({
47+
environmentId: "environment-1",
48+
operation: "connect",
49+
cause: new Error("upstream unavailable"),
50+
}),
51+
).pipe(
52+
Effect.withSpan("relay.test.schema_error"),
53+
Effect.exit,
54+
Effect.provide(
55+
makeRelayTraceLayer({
56+
tracesEndpoint: "/v1/traces",
57+
tracesDatasetName: "relay-test-traces",
58+
ingestToken: Redacted.make("test-token"),
59+
}),
8460
),
8561
);
86-
const payload = JSON.parse(request.body) as OtlpTracer.TraceData;
62+
63+
const request = yield* Deferred.await(exportedRequest).pipe(Effect.timeout("1 second"));
64+
const payload = (yield* decodeJson(request.body)) as OtlpTracer.TraceData;
8765
const span = payload.resourceSpans
8866
.flatMap((resourceSpan) => resourceSpan.scopeSpans)
8967
.flatMap((scopeSpan) => scopeSpan.spans)
@@ -95,25 +73,14 @@ it("exports schema error fields as span attributes", async () => {
9573
]),
9674
);
9775

98-
expect(request.headers.authorization).toBe("Bearer test-token");
99-
expect(request.headers["x-axiom-dataset"]).toBe("relay-test-traces");
76+
expect(request.authorization).toBe("Bearer test-token");
77+
expect(request.dataset).toBe("relay-test-traces");
10078
expect(attributes).toMatchObject({
10179
"error.type": "EnvironmentMintRequestFailed",
10280
"error.environmentId": "environment-1",
10381
"error.operation": "connect",
10482
"error.cause.name": "Error",
10583
"error.cause.message": "upstream unavailable",
10684
});
107-
} finally {
108-
await runtime.dispose();
109-
await new Promise<void>((resolve, reject) => {
110-
server.close((error) => {
111-
if (error) {
112-
reject(error);
113-
} else {
114-
resolve();
115-
}
116-
});
117-
});
118-
}
119-
});
85+
}).pipe(Effect.provide(NodeHttpServer.layerTest), Effect.scoped),
86+
);

0 commit comments

Comments
 (0)