fix(server): use waitForPush in terminal event broadcast test to prevent flaky failures

binbandit · binbandit · commit fe37f58adacf · 2026-03-09T14:13:26.000+11:00
The terminal RPC test used raw waitForMessage to receive the expected
terminal.event push, but a server.configUpdated push from the
keybindings file watcher can arrive first depending on OS timing.
Replace with the existing waitForPush helper that filters by channel.
diff --git a/apps/server/src/wsServer.test.ts b/apps/server/src/wsServer.test.ts
@@ -1333,9 +1333,7 @@ describe("WebSocket Server", () => {
     };
     terminalManager.emitEvent(manualEvent);
 
-    const push = (await waitForMessage(ws)) as WsPush;
-    expect(push.type).toBe("push");
-    expect(push.channel).toBe(WS_CHANNELS.terminalEvent);
+    const push = await waitForPush(ws, WS_CHANNELS.terminalEvent);
     expect((push.data as TerminalEvent).type).toBe("output");
   });
 
