@@ -117,10 +117,10 @@ nodeServicesIt("ACP native logging", (it) => {
117117 yield * protocolLogger ( {
118118 direction : "incoming" ,
119119 stage : "raw" ,
120- payload : encodeUnknownJson ( {
120+ payload : ` ${ encodeUnknownJson ( {
121121 method : "session/update" ,
122122 params : { update : { sessionUpdate : updateType } } ,
123- } ) ,
123+ } ) } \n` ,
124124 } ) ;
125125 yield * protocolLogger ( {
126126 direction : "incoming" ,
@@ -152,6 +152,90 @@ nodeServicesIt("ACP native logging", (it) => {
152152 } ) ,
153153 ) ;
154154
155+ it . effect ( "keeps mixed and incomplete raw diagnostics" , ( ) =>
156+ Effect . gen ( function * ( ) {
157+ const records : Array < unknown > = [ ] ;
158+ const makeLogger = yield * makeAcpNativeLoggerFactory ( ) ;
159+ const logger = makeLogger ( {
160+ nativeEventLogger : {
161+ filePath : "/tmp/provider-native.ndjson" ,
162+ write : ( event ) => Effect . sync ( ( ) => void records . push ( event ) ) ,
163+ close : ( ) => Effect . void ,
164+ } ,
165+ provider : ProviderDriverKind . make ( "cursor" ) ,
166+ threadId : ThreadId . make ( "thread-1" ) ,
167+ verboseProtocolLogging : true ,
168+ } ) ;
169+ const protocolLogger = logger . protocolLogging ?. logger ;
170+ assert . exists ( protocolLogger ) ;
171+ if ( ! protocolLogger ) return ;
172+
173+ const transient = encodeUnknownJson ( {
174+ method : "session/update" ,
175+ params : { update : { sessionUpdate : "agent_message_chunk" } } ,
176+ } ) ;
177+ const lifecycle = encodeUnknownJson ( { method : "session/new" , params : { } } ) ;
178+
179+ yield * protocolLogger ( {
180+ direction : "incoming" ,
181+ stage : "raw" ,
182+ payload : `${ transient } \n${ lifecycle } \n` ,
183+ } ) ;
184+ yield * protocolLogger ( {
185+ direction : "incoming" ,
186+ stage : "raw" ,
187+ payload : transient ,
188+ } ) ;
189+ yield * protocolLogger ( {
190+ direction : "incoming" ,
191+ stage : "raw" ,
192+ payload : `${ transient } \n{malformed}\n` ,
193+ } ) ;
194+
195+ assert . lengthOf ( records , 3 ) ;
196+ } ) ,
197+ ) ;
198+
199+ it . effect ( "filters transient entries from mixed decoded batches" , ( ) =>
200+ Effect . gen ( function * ( ) {
201+ const records : Array < unknown > = [ ] ;
202+ const makeLogger = yield * makeAcpNativeLoggerFactory ( ) ;
203+ const logger = makeLogger ( {
204+ nativeEventLogger : {
205+ filePath : "/tmp/provider-native.ndjson" ,
206+ write : ( event ) => Effect . sync ( ( ) => void records . push ( event ) ) ,
207+ close : ( ) => Effect . void ,
208+ } ,
209+ provider : ProviderDriverKind . make ( "grok" ) ,
210+ threadId : ThreadId . make ( "thread-1" ) ,
211+ verboseProtocolLogging : true ,
212+ } ) ;
213+ const protocolLogger = logger . protocolLogging ?. logger ;
214+ assert . exists ( protocolLogger ) ;
215+ if ( ! protocolLogger ) return ;
216+
217+ yield * protocolLogger ( {
218+ direction : "incoming" ,
219+ stage : "decoded" ,
220+ payload : [
221+ {
222+ _tag : "Request" ,
223+ tag : "session/update" ,
224+ payload : { update : { sessionUpdate : "agent_thought_chunk" } } ,
225+ } ,
226+ {
227+ _tag : "Request" ,
228+ tag : "session/new" ,
229+ payload : { } ,
230+ } ,
231+ ] ,
232+ } ) ;
233+
234+ assert . lengthOf ( records , 1 ) ;
235+ assert . include ( encodeUnknownJson ( records ) , '"itemCount":1' ) ;
236+ } ) ,
237+ ) ;
238+
155239 it . effect ( "logs a structural tag when the native writer defects" , ( ) => {
156240 const messages : Array < unknown > = [ ] ;
157241 const logCapture = Logger . make < unknown , void > ( ( { message } ) => {
0 commit comments