@@ -3,18 +3,21 @@ import {
33 type NavigationProp ,
44 type ParamListBase ,
55} from "@react-navigation/native" ;
6- import { act } from "react" ;
6+ import { AsyncResult } from "effect/reactivity" ;
7+ import { act , useLayoutEffect } from "react" ;
78import { createRoot } from "react-dom/client" ;
89import { expect , it , vi } from "vite-plus/test" ;
910
1011const mocks = vi . hoisted ( ( ) => ( {
12+ enabled : true ,
13+ generate : vi . fn ( ) ,
1114 query : {
12- data : null as { run : { _tag : "Running" | "Completed" } } | null ,
15+ data : null as { run : { _tag : "Running" | "Completed" | "Failed" } | null } | null ,
1316 isPending : false ,
1417 refresh : vi . fn < ( ) => void > ( ) ,
1518 } ,
1619 otherQuery : {
17- data : null as { run : { _tag : "Running" | "Completed" } } | null ,
20+ data : null as { run : { _tag : "Running" | "Completed" | "Failed" } | null } | null ,
1821 isPending : false ,
1922 refresh : vi . fn < ( ) => void > ( ) ,
2023 } ,
@@ -33,7 +36,8 @@ vi.mock("@react-navigation/native", async () => {
3336 return { NavigationContext, useFocusEffect } ;
3437} ) ;
3538vi . mock ( "@effect/atom-react" , ( ) => ( {
36- useAtomValue : ( atom : unknown ) => ( atom === "settings" ? { reviewGuidesEnabled : true } : true ) ,
39+ useAtomValue : ( atom : unknown ) =>
40+ atom === "settings" ? { reviewGuidesEnabled : mocks . enabled } : true ,
3741} ) ) ;
3842vi . mock ( "../../../state/server" , ( ) => ( {
3943 serverEnvironment : { settingsValueAtom : ( ) => "settings" } ,
@@ -48,7 +52,7 @@ vi.mock("../../../state/pull-requests", () => ({
4852vi . mock ( "../../../state/query" , ( ) => ( {
4953 useEnvironmentQuery : ( number : number ) => ( { ...( number === 1 ? mocks . query : mocks . otherQuery ) } ) ,
5054} ) ) ;
51- vi . mock ( "../../../state/use-atom-command" , ( ) => ( { useAtomCommand : ( ) => vi . fn ( ) } ) ) ;
55+ vi . mock ( "../../../state/use-atom-command" , ( ) => ( { useAtomCommand : ( ) => mocks . generate } ) ) ;
5256vi . mock ( "../usePullRequestConnected" , ( ) => ( { usePullRequestConnected : ( ) => true } ) ) ;
5357vi . mock ( "../usePullRequestDiff" , ( ) => ( {
5458 pullRequestTarget : ( params : unknown ) => params ,
@@ -78,6 +82,8 @@ function createNavigation() {
7882
7983function setup ( ) {
8084 ( globalThis as { IS_REACT_ACT_ENVIRONMENT ?: boolean } ) . IS_REACT_ACT_ENVIRONMENT = true ;
85+ mocks . enabled = true ;
86+ mocks . generate = vi . fn ( ) . mockResolvedValue ( AsyncResult . success ( undefined ) ) ;
8187 mocks . query = { data : null , isPending : false , refresh : vi . fn ( ) } ;
8288 mocks . otherQuery = { data : null , isPending : false , refresh : vi . fn ( ) } ;
8389 const root = createRoot ( document . createElement ( "div" ) ) ;
@@ -88,20 +94,35 @@ function setup() {
8894 repository : "repo" ,
8995 number : 1 ,
9096 } ;
91- function Probe ( { number, environmentId } : { number : number ; environmentId : string } ) {
92- useReviewGuide ( { ...params , number, environmentId } ) ;
97+ let current : ReturnType < typeof useReviewGuide > ;
98+ function Probe ( {
99+ number,
100+ environmentId,
101+ visible,
102+ } : {
103+ number : number ;
104+ environmentId : string ;
105+ visible ?: boolean ;
106+ } ) {
107+ const state = useReviewGuide ( { ...params , number, environmentId } , visible ) ;
108+ useLayoutEffect ( ( ) => {
109+ current = state ;
110+ } ) ;
93111 return null ;
94112 }
95113 return {
96- render ( number = 1 , environmentId = params . environmentId ) {
114+ render ( number = 1 , environmentId = params . environmentId , visible ?: boolean ) {
97115 act ( ( ) =>
98116 root . render (
99117 < NavigationContext . Provider value = { navigation . value } >
100- < Probe number = { number } environmentId = { environmentId } />
118+ < Probe number = { number } environmentId = { environmentId } visible = { visible } />
101119 </ NavigationContext . Provider > ,
102120 ) ,
103121 ) ;
104122 } ,
123+ get current ( ) {
124+ return current ;
125+ } ,
105126 focus : navigation . focus ,
106127 [ Symbol . dispose ] ( ) {
107128 act ( ( ) => root . unmount ( ) ) ;
@@ -188,3 +209,94 @@ it("retires the old environment's polling on target change and clears polling on
188209 expect ( mocks . otherQuery . refresh ) . toHaveBeenCalledTimes ( 2 ) ;
189210 expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
190211} ) ;
212+
213+ it ( "suspends only manual refresh while hidden, including focus and target changes" , ( ) => {
214+ vi . useFakeTimers ( ) ;
215+ using _timers = { [ Symbol . dispose ] : ( ) => vi . useRealTimers ( ) } ;
216+ {
217+ using screen = setup ( ) ;
218+ mocks . query . data = { run : { _tag : "Running" } } ;
219+ mocks . otherQuery . data = { run : { _tag : "Running" } } ;
220+ screen . render ( ) ;
221+ const cached = screen . current . data ;
222+ screen . render ( 1 , "environment" , false ) ;
223+ act ( ( ) => vi . advanceTimersByTime ( 60_000 ) ) ;
224+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 1 ) ;
225+ expect ( screen . current . data ) . toBe ( cached ) ;
226+ screen . render ( ) ;
227+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 2 ) ;
228+ act ( ( ) => vi . advanceTimersByTime ( 5_000 ) ) ;
229+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 3 ) ;
230+ screen . render ( 1 , "environment" , false ) ;
231+ screen . focus ( false ) ;
232+ screen . focus ( true ) ;
233+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 3 ) ;
234+
235+ screen . render ( 2 , "other-environment" , false ) ;
236+ act ( ( ) => vi . advanceTimersByTime ( 5_000 ) ) ;
237+ expect ( mocks . otherQuery . refresh ) . not . toHaveBeenCalled ( ) ;
238+ screen . focus ( false ) ;
239+ screen . render ( 2 , "other-environment" , true ) ;
240+ expect ( mocks . otherQuery . refresh ) . not . toHaveBeenCalled ( ) ;
241+ screen . focus ( true ) ;
242+ expect ( mocks . otherQuery . refresh ) . toHaveBeenCalledTimes ( 1 ) ;
243+ act ( ( ) => vi . advanceTimersByTime ( 5_000 ) ) ;
244+ expect ( mocks . otherQuery . refresh ) . toHaveBeenCalledTimes ( 2 ) ;
245+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 3 ) ;
246+ }
247+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
248+ } ) ;
249+
250+ it ( "keeps disabled, completed and failed guides idle and refreshes once on reveal" , ( ) => {
251+ vi . useFakeTimers ( ) ;
252+ using _timers = { [ Symbol . dispose ] : ( ) => vi . useRealTimers ( ) } ;
253+ using screen = setup ( ) ;
254+ mocks . enabled = false ;
255+ screen . render ( ) ;
256+ act ( ( ) => vi . advanceTimersByTime ( 5_000 ) ) ;
257+ expect ( mocks . query . refresh ) . not . toHaveBeenCalled ( ) ;
258+ mocks . enabled = true ;
259+ mocks . query . data = { run : null } ;
260+ screen . render ( ) ;
261+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 1 ) ;
262+ act ( ( ) => vi . advanceTimersByTime ( 10_000 ) ) ;
263+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 1 ) ;
264+ screen . render ( 1 , "environment" , false ) ;
265+ mocks . query . data = { run : { _tag : "Failed" } } ;
266+ screen . render ( 1 , "environment" , false ) ;
267+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 1 ) ;
268+ screen . render ( ) ;
269+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 2 ) ;
270+ act ( ( ) => vi . advanceTimersByTime ( 10_000 ) ) ;
271+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( 2 ) ;
272+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
273+ } ) ;
274+
275+ it ( "leaves generation running when hidden and accepts its completion without a refresh" , async ( ) => {
276+ vi . useFakeTimers ( ) ;
277+ using _timers = { [ Symbol . dispose ] : ( ) => vi . useRealTimers ( ) } ;
278+ using screen = setup ( ) ;
279+ const generated = Promise . withResolvers < ReturnType < typeof AsyncResult . success < void > > > ( ) ;
280+ mocks . generate . mockReturnValue ( generated . promise ) ;
281+ screen . render ( ) ;
282+ let writing : Promise < void > ;
283+ act ( ( ) => {
284+ writing = screen . current . write ( ) ;
285+ } ) ;
286+ expect ( screen . current . running ) . toBe ( true ) ;
287+ screen . render ( 1 , "environment" , false ) ;
288+ const beforeHidden = mocks . query . refresh . mock . calls . length ;
289+ act ( ( ) => vi . advanceTimersByTime ( 60_000 ) ) ;
290+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( beforeHidden ) ;
291+ expect ( mocks . generate ) . toHaveBeenCalledTimes ( 1 ) ;
292+ expect ( screen . current . running ) . toBe ( true ) ;
293+ await act ( async ( ) => {
294+ generated . resolve ( AsyncResult . success ( undefined ) ) ;
295+ await writing ;
296+ } ) ;
297+ expect ( screen . current . running ) . toBe ( false ) ;
298+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( beforeHidden ) ;
299+ screen . render ( ) ;
300+ expect ( mocks . query . refresh ) . toHaveBeenCalledTimes ( beforeHidden + 1 ) ;
301+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
302+ } ) ;
0 commit comments