Skip to content

Commit f91e14a

Browse files
fix(web): satisfy exactOptionalPropertyTypes for PR draft mode
Coerce optional runtime-mode inputs to null before passing them into resolvers so desktop/web typecheck stops failing under exactOptionalPropertyTypes. Co-authored-by: Cursor <[email protected]>
1 parent d41c637 commit f91e14a

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎apps/web/src/components/ChatView.logic.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -644,8 +644,8 @@ export function resolveNewPullRequestDraftRuntimeMode(sources: {
644644
}): RuntimeMode {
645645
return resolveNewThreadRuntimeMode({
646646
carryRuntimeMode: sources.composerRuntimeMode ?? sources.viewedThreadRuntimeMode ?? null,
647-
lastUsedRuntimeMode: sources.lastUsedRuntimeMode,
648-
configuredRuntimeMode: sources.configuredRuntimeMode,
647+
lastUsedRuntimeMode: sources.lastUsedRuntimeMode ?? null,
648+
configuredRuntimeMode: sources.configuredRuntimeMode ?? null,
649649
});
650650
}
651651

‎apps/web/src/components/ChatView.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2270,9 +2270,9 @@ export default function ChatView(props: ChatViewProps) {
22702270
const nextThreadId = newThreadId();
22712271
const resolvedRuntimeMode = resolveNewPullRequestDraftRuntimeMode({
22722272
composerRuntimeMode,
2273-
viewedThreadRuntimeMode: activeThread?.runtimeMode,
2273+
viewedThreadRuntimeMode: activeThread?.runtimeMode ?? null,
22742274
lastUsedRuntimeMode: getLastUsedRuntimeMode(logicalProjectKey),
2275-
configuredRuntimeMode: settings.defaultRuntimeMode,
2275+
configuredRuntimeMode: settings.defaultRuntimeMode ?? null,
22762276
});
22772277
setLogicalProjectDraftThreadId(logicalProjectKey, activeProjectRef, nextDraftId, {
22782278
threadId: nextThreadId,

0 commit comments

Comments
 (0)