Skip to content

Commit f8b204b

Browse files
refactor(server): keep telemetry identity errors private
1 parent eced382 commit f8b204b

2 files changed

Lines changed: 2 additions & 22 deletions

File tree

‎apps/server/src/telemetry/Identify.test.ts‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -33,26 +33,6 @@ const findIdentityLog = (
3333
errorTag: string,
3434
) => logs.find((log) => log.annotations.source === source && log.annotations.errorTag === errorTag);
3535

36-
it("preserves exact telemetry identity causes without deriving messages from them", () => {
37-
const decodeCause = new Error("private nested decode details");
38-
const decodeError = new Identify.TelemetryIdentityDecodeError({
39-
source: "codex",
40-
filePath: "/tmp/auth.json",
41-
cause: decodeCause,
42-
});
43-
const readCause = new Error("private nested read details");
44-
const readError = new Identify.TelemetryIdentityReadError({
45-
source: "anonymous",
46-
filePath: "/tmp/anonymous-id",
47-
cause: readCause,
48-
});
49-
50-
assert.strictEqual(decodeError.cause, decodeCause);
51-
assert.strictEqual(readError.cause, readCause);
52-
assert.notInclude(decodeError.message, decodeCause.message);
53-
assert.notInclude(readError.message, readCause.message);
54-
});
55-
5636
it.layer(NodeServices.layer)("telemetry identity", (it) => {
5737
it.effect("uses the persisted anonymous id when provider identities are absent", () =>
5838
Effect.gen(function* () {

‎apps/server/src/telemetry/Identify.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const ClaudeJsonSchema = Schema.Struct({
2323
export const TelemetryIdentitySource = Schema.Literals(["codex", "claude", "anonymous"]);
2424
export type TelemetryIdentitySource = typeof TelemetryIdentitySource.Type;
2525

26-
export class TelemetryIdentityReadError extends Schema.TaggedErrorClass<TelemetryIdentityReadError>()(
26+
class TelemetryIdentityReadError extends Schema.TaggedErrorClass<TelemetryIdentityReadError>()(
2727
"TelemetryIdentityReadError",
2828
{
2929
source: TelemetryIdentitySource,
@@ -36,7 +36,7 @@ export class TelemetryIdentityReadError extends Schema.TaggedErrorClass<Telemetr
3636
}
3737
}
3838

39-
export class TelemetryIdentityDecodeError extends Schema.TaggedErrorClass<TelemetryIdentityDecodeError>()(
39+
class TelemetryIdentityDecodeError extends Schema.TaggedErrorClass<TelemetryIdentityDecodeError>()(
4040
"TelemetryIdentityDecodeError",
4141
{
4242
source: Schema.Literals(["codex", "claude"]),

0 commit comments

Comments
 (0)