Skip to content

Commit f82a3cc

Browse files
committed
fix(device): use expo-device-hub 0.19.1
- Remove the simulator AVC workaround now handled by the hub release
1 parent 5fe18d7 commit f82a3cc

6 files changed

Lines changed: 3 additions & 301 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"agent-device": "0.21.31",
3-
"expo-device-hub": "0.19.0-canary-20261023-1357114"
3+
"expo-device-hub": "0.19.1"
44
}

‎docs/internals/devices.md‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,7 @@ binary WebSocket; Android multiplexes SEMU-framed H.264 and JSON gestures over
141141
one WebSocket. [`DeviceStreamView.tsx`](../../apps/web/src/components/device/DeviceStreamView.tsx)
142142
speaks both so one panel covers both platforms.
143143

144-
Simulators encode H.264 High 5.1 without frame reordering, but the hub's fallback
145-
encoder can omit the SPS VUI that declares its reorder limits. Chromium's hardware
146-
decoder then retains frames for seconds despite `optimizeForLatency` and an empty
147-
`decodeQueueSize`. The iOS AVCC viewer restores the missing metadata before
148-
configuring the decoder so hardware decoding can remain enabled. WebCodecs is
149-
secure-context only, so the viewer probes `isConfigSupported` and falls back to
144+
WebCodecs is secure-context only, so the viewer probes `isConfigSupported` and falls back to
150145
MJPEG on iOS when decoding is unavailable. Android's SEMU socket has no MJPEG;
151146
there the panel reports that it cannot decode.
152147

‎packages/client-runtime/src/device/avcConfig.test.ts‎

Lines changed: 0 additions & 122 deletions
This file was deleted.

‎packages/client-runtime/src/device/avcConfig.ts‎

Lines changed: 0 additions & 140 deletions
This file was deleted.

‎packages/client-runtime/src/device/stream.test.ts‎

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -421,36 +421,6 @@ describe("shared device stream readiness and recovery", () => {
421421
vi.unstubAllGlobals();
422422
});
423423

424-
it("repairs the hub's fallback configuration without disabling hardware decoding", async () => {
425-
const { client, videoBodies, Decoder } = recoveryFixture("ios", false);
426-
try {
427-
client.start();
428-
await vi.advanceTimersByTimeAsync(0);
429-
videoBodies[0]!.enqueue(
430-
Uint8Array.from(
431-
envelope(
432-
1,
433-
[
434-
1, 100, 0, 51, 255, 225, 0, 12, 39, 100, 0, 51, 172, 86, 128, 76, 1, 73, 230, 164, 1,
435-
0, 4, 40, 238, 60, 176,
436-
],
437-
),
438-
),
439-
);
440-
await vi.advanceTimersByTimeAsync(0);
441-
expect(Decoder.isConfigSupported).toHaveBeenCalledExactlyOnceWith({
442-
codec: "avc1.640033",
443-
description: Uint8Array.from([
444-
1, 100, 0, 51, 255, 225, 0, 17, 39, 100, 0, 51, 172, 86, 128, 76, 1, 73, 230, 168, 6, 208,
445-
68, 35, 80, 1, 0, 4, 40, 238, 60, 176,
446-
]),
447-
optimizeForLatency: true,
448-
});
449-
} finally {
450-
client.stop();
451-
}
452-
});
453-
454424
it("streams and drives a serve-sim-only Android device over serve-sim's AVCC and input socket", async () => {
455425
const { client, events, fetch, sockets, videoBodies, decoders } = recoveryFixture(
456426
"android",

‎packages/client-runtime/src/device/stream.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {
99
import * as Schema from "effect/Schema";
1010
import * as Option from "effect/Option";
1111
import { createCanvasFrameSink, type DeviceFrameSink } from "./frame.ts";
12-
import { simulatorAvcConfig } from "./avcConfig.ts";
1312
import { type DeviceHubAccess, withDeviceHubQuery } from "./hubAccess.ts";
1413
import type { DevicePlatform } from "@t3tools/contracts";
1514

@@ -781,7 +780,7 @@ export function createDeviceStreamClient(
781780
const configured = await configureDecoder(
782781
{
783782
codec: avcCodecString(chunk.payload),
784-
description: simulatorAvcConfig(chunk.payload),
783+
description: chunk.payload,
785784
},
786785
isCurrent,
787786
);

0 commit comments

Comments
 (0)