Repository navigation
Commit f70e95a
fix(ssh): do not reuse an askpass runtime path that is now a symlink
The reuse check used stat, which follows symlinks. If a temp cleaner
removed the cached runtime directory and someone created a symlink with
the same name pointing at a directory the user owns, the check passed and
the helper was written through the symlink. Whoever owns the symlink could
then repoint it before ssh runs the helper.
Cache the resolved path of the new temp directory, and reuse it only while
it still resolves to itself and is a directory owned by the current user.
Resolving the new directory keeps reuse working when TMPDIR is itself a
symlink, as on macOS.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 8f78741 commit f70e95a
2 files changed
Lines changed: 33 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
90 | 117 | | |
91 | 118 | | |
92 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
| 179 | + | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
| 182 | + | |
182 | 183 | | |
183 | 184 | | |
184 | 185 | | |
| |||
190 | 191 | | |
191 | 192 | | |
192 | 193 | | |
193 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
194 | 197 | | |
195 | 198 | | |
196 | 199 | | |
| |||
0 commit comments