Skip to content

Commit f6e6a04

Browse files
t3dotggclaude
andcommitted
fix(server): first provider check reads settings under the refresh lock
Co-Authored-By: Claude Fable 5.2 <[email protected]>
1 parent 6e8b0e6 commit f6e6a04

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

‎packages/provider-core/src/server/managedProvider.ts‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,8 +439,14 @@ export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(
439439

440440
// Probes spawn provider CLIs; starting them during server startup slows the first client load.
441441
yield* (host.awaitServerReady ?? Effect.void).pipe(
442-
Effect.andThen(Ref.get(settingsRef)),
443-
Effect.flatMap((settings) => applySnapshot(settings, { forceRefresh: true })),
442+
Effect.andThen(
443+
// Read under the lock, so a settings check in flight cannot be overwritten with older settings.
444+
refreshSemaphore.withPermits(1)(
445+
Ref.get(settingsRef).pipe(
446+
Effect.flatMap((settings) => applySnapshotBase(settings, { forceRefresh: true })),
447+
),
448+
),
449+
),
444450
Effect.ignoreCause({ log: true }),
445451
Effect.forkScoped,
446452
);

0 commit comments

Comments
 (0)