Skip to content

Commit f623cad

Browse files
fix(mobile): stop refreshing Git status on streamed thread updates
1 parent 7b0dc7b commit f623cad

1 file changed

Lines changed: 18 additions & 4 deletions

File tree

‎apps/mobile/src/state/use-selected-thread-git-actions.ts‎

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useCallback, useEffect, useMemo } from "react";
1+
import { useCallback, useEffect, useEffectEvent, useMemo } from "react";
22

33
import { EnvironmentProject, EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
44
import type { AtomCommandResult } from "@t3tools/client-runtime/state/runtime";
@@ -115,12 +115,26 @@ export function useSelectedThreadGitActions() {
115115
[refreshStatus, selectedThread, selectedThreadCwd, selectedThreadProject],
116116
);
117117

118+
// Shell updates replace the selected thread object many times per second while a
119+
// turn streams, so key the refresh on primitives. The server publishes status after
120+
// each turn finishes; this only seeds status when the selection or cwd changes.
121+
const selectedEnvironmentId = selectedThread?.environmentId ?? null;
122+
const selectedThreadId = selectedThread?.id ?? null;
123+
const hasSelectedThreadProject = selectedThreadProject !== null;
124+
const refreshOnSelection = useEffectEvent(() => {
125+
void refreshSelectedThreadGitStatus({ quiet: true });
126+
});
118127
useEffect(() => {
119-
if (!selectedThread || !selectedThreadProject) {
128+
if (
129+
selectedEnvironmentId === null ||
130+
selectedThreadId === null ||
131+
!hasSelectedThreadProject ||
132+
selectedThreadCwd === null
133+
) {
120134
return;
121135
}
122-
void refreshSelectedThreadGitStatus({ quiet: true });
123-
}, [refreshSelectedThreadGitStatus, selectedThread, selectedThreadProject]);
136+
refreshOnSelection();
137+
}, [selectedEnvironmentId, selectedThreadId, hasSelectedThreadProject, selectedThreadCwd]);
124138

125139
const runSelectedThreadGitMutation = useCallback(
126140
async <T, E>(

0 commit comments

Comments
 (0)