@@ -187,7 +187,7 @@ describe("getChangeRequest base freshness", () => {
187187 Effect . provide (
188188 Layer . mock ( GitLabPullRequestCli . GitLabPullRequestCli ) ( {
189189 getMergeRequestDetail : ( ) => Effect . succeed ( detail ) ,
190- getReviewDecisions : ( ) => Effect . succeed ( new Map ( ) ) ,
190+ getListStates : ( ) => Effect . succeed ( new Map ( ) ) ,
191191
192192 listMergeRequestStats : ( ) => Effect . succeed ( [ ] ) ,
193193 } ) ,
@@ -288,7 +288,7 @@ describe("getChangeRequest base freshness", () => {
288288 Layer . mock ( GitLabPullRequestCli . GitLabPullRequestCli ) ( {
289289 getMergeRequestDetail : ( ) => Effect . succeed ( detail ) ,
290290 getProjectMergeCapabilities : ( ) => Effect . die ( "linked threads skip merge settings" ) ,
291- getReviewDecisions : ( ) => Effect . succeed ( new Map ( ) ) ,
291+ getListStates : ( ) => Effect . succeed ( new Map ( ) ) ,
292292 listMergeRequestStats : ( ) =>
293293 Effect . succeed ( [ { repository : "acme/web" , number : 7 , additions : 40 , deletions : 2 } ] ) ,
294294 } ) ,
@@ -336,7 +336,7 @@ describe("merge request reads", () => {
336336 Effect . provide (
337337 Layer . mock ( GitLabPullRequestCli . GitLabPullRequestCli ) ( {
338338 listMergeRequestStats : ( ) => Effect . succeed ( [ ] ) ,
339- getReviewDecisions : ( ) => Effect . succeed ( new Map ( ) ) ,
339+ getListStates : ( ) => Effect . succeed ( new Map ( ) ) ,
340340 getMergeRequestDetail : ( input ) =>
341341 Effect . sync ( ( ) => {
342342 calls . detail += 1 ;
@@ -594,7 +594,7 @@ describe("review decisions", () => {
594594 reviewerIds : [ ] ,
595595 } ;
596596 const providerWith = (
597- getReviewDecisions : GitLabPullRequestCli . GitLabPullRequestCli [ "Service" ] [ "getReviewDecisions " ] ,
597+ getListStates : GitLabPullRequestCli . GitLabPullRequestCli [ "Service" ] [ "getListStates " ] ,
598598 ) =>
599599 make . pipe (
600600 Effect . provide (
@@ -606,7 +606,7 @@ describe("review decisions", () => {
606606 cursorAdvance : 2 ,
607607 } ) ,
608608 getMergeRequestDetail : ( ) => Effect . succeed ( detail ) ,
609- getReviewDecisions ,
609+ getListStates ,
610610 listMergeRequestStats : ( ) =>
611611 Effect . succeed ( [ { repository : "acme/web" , number : 7 , additions : 40 , deletions : 2 } ] ) ,
612612 } ) ,
@@ -622,26 +622,33 @@ describe("review decisions", () => {
622622 limit : 2 ,
623623 } ;
624624
625- it . effect ( "puts GitLab's approval state on listed and summarized merge requests" , ( ) =>
626- Effect . gen ( function * ( ) {
627- const provider = yield * providerWith ( ( input ) => {
628- expect ( input . host ) . toBe ( reference . host ) ;
629- return Effect . succeed (
630- new Map ( [
631- [ 7 , "approved" as const ] ,
632- [ 8 , null ] ,
633- ] ) ,
634- ) ;
635- } ) ;
636- const listed = yield * provider . listChangeRequests ( listing ) ;
637- assert . isDefined ( provider . getChangeRequestSummary ) ;
638- const summary = yield * provider . getChangeRequestSummary ( reference ) ;
639-
640- expect ( listed . items . map ( ( { reviewDecision } ) => reviewDecision ) ) . toEqual ( [ "approved" , null ] ) ;
641- expect ( summary . reviewDecision ) . toBe ( "approved" ) ;
642- expect ( summary . additions ) . toBe ( 40 ) ;
643- expect ( summary . deletions ) . toBe ( 2 ) ;
644- } ) ,
625+ it . effect (
626+ "puts GitLab's approval and pipeline state on listed and summarized merge requests" ,
627+ ( ) =>
628+ Effect . gen ( function * ( ) {
629+ const provider = yield * providerWith ( ( input ) => {
630+ expect ( input . host ) . toBe ( reference . host ) ;
631+ return Effect . succeed (
632+ new Map ( [
633+ [ 7 , { reviewDecision : "approved" as const , checksState : "failing" as const } ] ,
634+ [ 8 , { reviewDecision : null , checksState : null } ] ,
635+ ] ) ,
636+ ) ;
637+ } ) ;
638+ const listed = yield * provider . listChangeRequests ( listing ) ;
639+ assert . isDefined ( provider . getChangeRequestSummary ) ;
640+ const summary = yield * provider . getChangeRequestSummary ( reference ) ;
641+
642+ expect ( listed . items . map ( ( { reviewDecision } ) => reviewDecision ) ) . toEqual ( [
643+ "approved" ,
644+ null ,
645+ ] ) ;
646+ expect ( listed . items . map ( ( { checksState } ) => checksState ) ) . toEqual ( [ "failing" , null ] ) ;
647+ expect ( summary . reviewDecision ) . toBe ( "approved" ) ;
648+ expect ( summary . checksState ) . toBe ( "failing" ) ;
649+ expect ( summary . additions ) . toBe ( 40 ) ;
650+ expect ( summary . deletions ) . toBe ( 2 ) ;
651+ } ) ,
645652 ) ;
646653
647654 it . effect . each ( [
@@ -650,7 +657,7 @@ describe("review decisions", () => {
650657 error : new GitLabPullRequestCli . GitLabMergeRequestReadError ( {
651658 command : "glab" ,
652659 cwd : "/w" ,
653- operation : "getReviewDecisions " ,
660+ operation : "getListStates " ,
654661 cause : null ,
655662 } ) ,
656663 } ,
0 commit comments