Skip to content

Commit f2ae390

Browse files
Dwiteclaudemaria-rcks
authored
fix(mobile): give Android reply actions 48dp touch targets (#27020)
Co-authored-by: Claude Opus 5.5 <[email protected]> Co-authored-by: maria-rcks <[email protected]>
1 parent fd08b17 commit f2ae390

1 file changed

Lines changed: 24 additions & 3 deletions

File tree

‎apps/mobile/src/features/threads/ThreadFeed.tsx‎

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ import { CopyTextButton } from "./CopyTextButton";
167167
import { getReviewSectionIdForCheckpoint } from "../review/reviewModel";
168168
import { setReviewSelectedSectionId } from "../review/reviewState";
169169
import { Menu } from "../../components/ui/Menu";
170+
import { useAndroidControlSizing } from "../../components/ui/useAndroidControlSizing";
170171
import { copyPromptLink } from "../prompt-links/prompt-link-actions";
171172
import { parseReviewCommentMessageSegments } from "../review/reviewCommentSelection";
172173
import {
@@ -420,6 +421,8 @@ function UserMessageCopyButton(props: {
420421
function AssistantForkButton(props: {
421422
readonly environmentId: EnvironmentId;
422423
readonly iconColor: ColorValue;
424+
readonly buttonSize: number;
425+
readonly iconSize: number;
423426
readonly projectedItem: OrchestrationV2ProjectedTurnItem;
424427
readonly sourceTitle: string;
425428
}) {
@@ -476,13 +479,18 @@ function AssistantForkButton(props: {
476479
.finally(() => setBusy(false));
477480
}}
478481
className="h-7 w-7 items-center justify-center disabled:opacity-40"
482+
style={
483+
Platform.OS === "android"
484+
? { width: props.buttonSize, height: props.buttonSize }
485+
: undefined
486+
}
479487
>
480488
{busy ? (
481489
<AppActivityIndicator size="small" />
482490
) : (
483491
<SymbolView
484492
name="arrow.triangle.branch"
485-
size={13}
493+
size={props.iconSize}
486494
tintColor={props.iconColor}
487495
type="monochrome"
488496
/>
@@ -1597,6 +1605,7 @@ function renderFeedEntry(
15971605
readonly renderViewedImage: MarkdownImageRenderer;
15981606
readonly renderReasoning: (text: string) => ReactNode;
15991607
readonly iconSubtleColor: string | import("react-native").ColorValue;
1608+
readonly replyActionSize: { readonly button: number; readonly icon: number };
16001609
readonly screenColor: string;
16011610
readonly userBubbleColor: string | import("react-native").ColorValue;
16021611
readonly markdownStyles: MarkdownStyleSets;
@@ -2195,13 +2204,15 @@ function renderFeedEntry(
21952204
accessibilityLabel="Copy message"
21962205
text={renderedText}
21972206
tintColor={iconSubtleColor}
2198-
buttonSize={28}
2199-
iconSize={13}
2207+
buttonSize={props.replyActionSize.button}
2208+
iconSize={props.replyActionSize.icon}
22002209
/>
22012210
{message.projectedItem ? (
22022211
<AssistantForkButton
22032212
environmentId={props.environmentId}
22042213
iconColor={iconSubtleColor}
2214+
buttonSize={props.replyActionSize.button}
2215+
iconSize={props.replyActionSize.icon}
22052216
projectedItem={message.projectedItem}
22062217
sourceTitle={props.threadTitle}
22072218
/>
@@ -2665,6 +2676,15 @@ export const ThreadFeed = memo(function ThreadFeed({
26652676

26662677
const theme = useUniwindTheme();
26672678
const iconSubtleColor = theme["--color-icon-subtle"];
2679+
const { buttonSize: androidButtonSize, smallIconSize: androidIconSize } =
2680+
useAndroidControlSizing();
2681+
const replyActionSize = useMemo(
2682+
() =>
2683+
Platform.OS === "android"
2684+
? { button: androidButtonSize, icon: androidIconSize }
2685+
: { button: 28, icon: 13 },
2686+
[androidButtonSize, androidIconSize],
2687+
);
26682688
const screenColor = theme["--color-screen"];
26692689
const userBubbleColor = theme["--color-user-bubble"];
26702690
const openSkillInstructions = (path: string) => {
@@ -3520,6 +3540,7 @@ export const ThreadFeed = memo(function ThreadFeed({
35203540
renderViewedImage,
35213541
renderReasoning,
35223542
iconSubtleColor,
3543+
replyActionSize,
35233544
screenColor,
35243545
userBubbleColor,
35253546
markdownStyles,

0 commit comments

Comments
 (0)