Skip to content

Commit f0a124d

Browse files
committed
fix(clients): show enabled thinking without an effort selector
1 parent 284dd5e commit f0a124d

2 files changed

Lines changed: 18 additions & 8 deletions

File tree

‎packages/client-runtime/src/modelTraits.test.ts‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@ import { buildTraitsTriggerDisplay } from "./modelTraits.ts";
55

66
describe("composer thinking summary", () => {
77
it.each([
8-
{ thinking: true, toggleFirst: false, label: "Extra High · 1M" },
9-
{ thinking: true, toggleFirst: true, label: "Extra High · 1M" },
10-
{ thinking: false, toggleFirst: false, label: "Off · 1M" },
11-
{ thinking: false, toggleFirst: true, label: "Off · 1M" },
8+
{ thinking: true, toggleFirst: false, effort: true, label: "Extra High · 1M" },
9+
{ thinking: true, toggleFirst: true, effort: true, label: "Extra High · 1M" },
10+
{ thinking: false, toggleFirst: false, effort: true, label: "Off · 1M" },
11+
{ thinking: false, toggleFirst: true, effort: true, label: "Off · 1M" },
12+
{ thinking: true, toggleFirst: true, effort: false, label: "Thinking · 1M" },
13+
{ thinking: false, toggleFirst: true, effort: false, label: "Off · 1M" },
1214
])("shows $label with thinking=$thinking and toggleFirst=$toggleFirst", (testCase) => {
1315
const thinking: ProviderOptionDescriptor = {
1416
id: "thinking",
@@ -24,7 +26,11 @@ describe("composer thinking summary", () => {
2426
options: [{ id: "xhigh", label: "Extra High" }],
2527
};
2628
const descriptors: Array<ProviderOptionDescriptor> = [
27-
...(testCase.toggleFirst ? [thinking, effort] : [effort, thinking]),
29+
...(testCase.effort
30+
? testCase.toggleFirst
31+
? [thinking, effort]
32+
: [effort, thinking]
33+
: [thinking]),
2834
{
2935
id: "contextWindow",
3036
label: "Context Window",
@@ -37,7 +43,7 @@ describe("composer thinking summary", () => {
3743
buildTraitsTriggerDisplay({
3844
provider: ProviderDriverKind.make("claudeAgent"),
3945
descriptors,
40-
primarySelectDescriptorId: "effort",
46+
primarySelectDescriptorId: testCase.effort ? "effort" : "contextWindow",
4147
ultrathinkPromptControlled: false,
4248
}),
4349
).toMatchObject({

‎packages/client-runtime/src/modelTraits.ts‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,19 @@ export function buildTraitsTriggerDisplay(input: {
116116
descriptor.type === "boolean" &&
117117
descriptor.currentValue === false,
118118
);
119+
const hasReasoningSelect = input.descriptors.some(
120+
(descriptor) =>
121+
descriptor.type === "select" && REASONING_SELECT_DESCRIPTOR_IDS.has(descriptor.id),
122+
);
119123
let fastModeFallbackLabel: string | null = null;
120124
let speedLabel: string | null = null;
121125
let reasoningLabelIndex = -1;
122126
const labels: Array<string> = [];
123127
for (const descriptor of input.descriptors) {
124128
if (descriptor.id === "thinking" && descriptor.type === "boolean") {
125-
if (thinkingOff) {
129+
if (thinkingOff || (!hasReasoningSelect && descriptor.currentValue === true)) {
126130
reasoningLabelIndex = labels.length;
127-
labels.push("Off");
131+
labels.push(thinkingOff ? "Off" : "Thinking");
128132
}
129133
continue;
130134
}

0 commit comments

Comments
 (0)