Skip to content

Commit eff2c0b

Browse files
committed
"claude system message" instead of "runtime warning" when using 4.8 from claude code
1 parent 92be60e commit eff2c0b

2 files changed

Lines changed: 51 additions & 3 deletions

File tree

‎apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,9 @@ function runtimeEventToActivities(
351351
createdAt: event.createdAt,
352352
tone: "info",
353353
kind: "runtime.warning",
354-
summary: "Runtime warning",
354+
// Use the adapter-supplied message as the row label so the work log
355+
// shows what the warning was about, not a generic "Runtime warning".
356+
summary: truncateDetail(event.payload.message, 120),
355357
payload: {
356358
message: truncateDetail(event.payload.message),
357359
...(event.payload.detail !== undefined ? { detail: event.payload.detail } : {}),

‎apps/server/src/provider/Layers/ClaudeAdapter.ts‎

Lines changed: 48 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -972,6 +972,52 @@ function sdkNativeMethod(message: SDKMessage): string {
972972
return `claude/${message.type}`;
973973
}
974974

975+
// Discriminator/identity keys carry no human-readable content; everything else
976+
// on an unmodeled SDK message is potentially worth surfacing in the work log.
977+
const SDK_MESSAGE_NOISE_KEYS = new Set([
978+
"type",
979+
"subtype",
980+
"uuid",
981+
"parent_uuid",
982+
"session_id",
983+
"parent_tool_use_id",
984+
"request_id",
985+
]);
986+
987+
// Pull the salient scalar content out of a message the adapter doesn't model
988+
// yet, so the work-log row shows what actually arrived (e.g. a notification's
989+
// text) instead of an opaque "unhandled subtype" placeholder. Nested structures
990+
// are left to the full payload retained in the event's `detail`.
991+
function previewUnknownSdkContent(message: unknown): string | undefined {
992+
if (!message || typeof message !== "object") {
993+
return undefined;
994+
}
995+
const parts: string[] = [];
996+
for (const [key, value] of Object.entries(message as Record<string, unknown>)) {
997+
if (SDK_MESSAGE_NOISE_KEYS.has(key)) {
998+
continue;
999+
}
1000+
if (typeof value === "string") {
1001+
const trimmed = value.trim();
1002+
if (trimmed.length > 0) {
1003+
parts.push(`${key}: ${trimmed}`);
1004+
}
1005+
} else if (typeof value === "number" || typeof value === "boolean") {
1006+
parts.push(`${key}: ${String(value)}`);
1007+
}
1008+
}
1009+
if (parts.length === 0) {
1010+
return undefined;
1011+
}
1012+
const joined = parts.join(" · ");
1013+
return joined.length > 280 ? `${joined.slice(0, 279)}…` : joined;
1014+
}
1015+
1016+
function describeUnknownSdkMessage(kind: string, message: unknown): string {
1017+
const preview = previewUnknownSdkContent(message);
1018+
return preview ? `${kind} — ${preview}` : `${kind} (no displayable text content)`;
1019+
}
1020+
9751021
function sdkNativeItemId(message: SDKMessage): string | undefined {
9761022
if (message.type === "assistant") {
9771023
const maybeId = (message.message as { id?: unknown }).id;
@@ -2270,7 +2316,7 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
22702316
default:
22712317
yield* emitRuntimeWarning(
22722318
context,
2273-
`Unhandled Claude system message subtype '${message.subtype}'.`,
2319+
describeUnknownSdkMessage(`Claude system message '${message.subtype}'`, message),
22742320
message,
22752321
);
22762322
return;
@@ -2384,7 +2430,7 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
23842430
default:
23852431
yield* emitRuntimeWarning(
23862432
context,
2387-
`Unhandled Claude SDK message type '${message.type}'.`,
2433+
describeUnknownSdkMessage(`Claude SDK message '${message.type}'`, message),
23882434
message,
23892435
);
23902436
return;

0 commit comments

Comments
 (0)