Skip to content

Commit eeb4b96

Browse files
t3dotggclaude
andcommitted
fix(web): explain a non-actionable desktop update in the picker
An old desktop-managed server keeps its arrow on the picker trigger. The update row now stays, disabled, and says to update the desktop app on that machine instead of vanishing. Co-Authored-By: Claude Fable 5.1 <[email protected]>
1 parent 7ecb443 commit eeb4b96

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

‎apps/web/src/components/BranchToolbarEnvironmentSelector.tsx‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,15 @@ const environmentIdFromValue = (value: string | null) =>
3737
function ServerUpdateSelectItem({
3838
label,
3939
serverLabel,
40+
disabled = false,
4041
}: {
4142
readonly label: string;
4243
readonly serverLabel: string;
44+
/** No remote path: the row explains the arrow and takes no click. */
45+
readonly disabled?: boolean;
4346
}) {
4447
return (
45-
<SelectItem value={UPDATE_SERVER_VALUE}>
48+
<SelectItem value={UPDATE_SERVER_VALUE} disabled={disabled}>
4649
<span className="inline-flex items-center gap-1.5">
4750
<CircleArrowUpIcon aria-hidden="true" className="size-3 text-foreground" />
4851
{label} {serverLabel}
@@ -305,12 +308,17 @@ export const BranchToolbarEnvironmentSelector = memo(function BranchToolbarEnvir
305308
</SelectItem>
306309
))}
307310
</SelectGroup>
308-
{serverUpdate && serverUpdateTrigger.actionable ? (
311+
{serverUpdate ? (
309312
<>
310313
<SelectSeparator />
311314
<ServerUpdateSelectItem
312-
label={serverUpdateTrigger.label}
315+
label={
316+
serverUpdateTrigger.actionable
317+
? serverUpdateTrigger.label
318+
: "Update the desktop app on"
319+
}
313320
serverLabel={serverUpdate.serverLabel}
321+
disabled={!serverUpdateTrigger.actionable}
314322
/>
315323
</>
316324
) : null}

0 commit comments

Comments
 (0)