Skip to content

Commit ee0371e

Browse files
esthoresthor
committed
chore(deps): correct what the Crypto opt-outs say Effect lacks
Effect's Crypto has `digest`, `randomBytes`, and UUIDs, so the opt-outs that said it has no `createHash` or `randomBytes` were wrong. Name only the APIs it lacks, and where a file needs only hashing or ids, say that the Node call is synchronous and Effect's is an Effect.
1 parent de49581 commit ee0371e

34 files changed

Lines changed: 34 additions & 34 deletions

‎apps/desktop/src/preview/Manager.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* elements live in the renderer; we only attach listeners and forward state
66
* here). Single layer-scoped browser session partition.
77
*/
8-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses a synchronous UUID; Effect's Crypto.randomUUIDv4 is an Effect.
8+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses Node's synchronous randomUUID; Effect's Crypto.randomUUIDv4 is an Effect.
99
import * as NodeCrypto from "node:crypto";
1010
import {
1111
DesktopPreviewRecordingInputSchema,

‎apps/server/src/assets/AttachmentUpload.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses a synchronous UUID; Effect's Crypto.randomUUIDv4 is an Effect.
1+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses Node's synchronous randomUUID; Effect's Crypto.randomUUIDv4 is an Effect.
22
import * as NodeCrypto from "node:crypto";
33

44
import {

‎apps/server/src/assets/NativeAppIconResolver.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- Effect's Crypto has no createHash.
1+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses Node's synchronous createHash and randomUUID; Effect's Crypto has digest and randomUUIDv4 as Effects.
22
import * as NodeCrypto from "node:crypto";
33
import type { ToolActivityNativeAppReference } from "@t3tools/contracts";
44
import * as Cache from "effect/Cache";

‎apps/server/src/auth/ReusableDevAuth.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- Effect's Crypto has no createHash or timingSafeEqual.
1+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- Effect's Crypto has no timingSafeEqual.
22
import * as NodeCrypto from "node:crypto";
33
import { AuthSessionId } from "@t3tools/contracts";
44
import * as DateTime from "effect/DateTime";

‎apps/server/src/auth/utils.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type {
44
AuthClientPresentationMetadata,
55
} from "@t3tools/contracts";
66
import type * as HttpServerRequest from "effect/http/HttpServerRequest";
7-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- Effect's Crypto has no createHash, createHmac, or timingSafeEqual.
7+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- Effect's Crypto has no createHmac or timingSafeEqual.
88
import * as NodeCrypto from "node:crypto";
99
import * as Base64Url from "effect/encoding/Base64Url";
1010
import * as Result from "effect/Result";

‎apps/server/src/cli/app.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// @effect-diagnostics globalTimers:off -- The Node socket client owns its response deadline and clears it on every completion path.
2-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses a synchronous UUID; Effect's Crypto.randomUUIDv4 is an Effect.
2+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses Node's synchronous randomUUID; Effect's Crypto.randomUUIDv4 is an Effect.
33
import * as NodeCrypto from "node:crypto";
44
import * as NodeNet from "node:net";
55
import * as NodeOS from "node:os";

‎apps/server/src/device/AgentDeviceTarget.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- Effect's Crypto has no createHash.
1+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses Node's synchronous createHash; Effect's Crypto.digest is an Effect.
22
import * as NodeCrypto from "node:crypto";
33
import * as Schema from "effect/Schema";
44
import * as Effect from "effect/Effect";

‎apps/server/src/device/SshDeviceHost.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- Effect's Crypto has no createHash.
1+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses Node's synchronous createHash; Effect's Crypto.digest is an Effect.
22
import * as NodeCrypto from "node:crypto";
33
import {
44
type DeviceHostSummary,

‎apps/server/src/htmlRender/PreviewBrowser.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import * as Path from "effect/Path";
1212
import * as Stream from "effect/Stream";
1313
import * as TestClock from "effect/testing/TestClock";
1414
import { HttpClient, HttpClientResponse } from "effect/http";
15-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- Effect's Crypto has no createHash.
15+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses Node's synchronous createHash; Effect's Crypto.digest is an Effect.
1616
import * as NodeCrypto from "node:crypto";
1717
import * as NodeZlib from "node:zlib";
1818

‎apps/server/src/mcp/McpHttpServer.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses a synchronous UUID; Effect's Crypto.randomUUIDv4 is an Effect.
1+
// @effect-diagnostics-next-line nodeBuiltinImport:off -- uses Node's synchronous randomUUID; Effect's Crypto.randomUUIDv4 is an Effect.
22
import * as NodeCrypto from "node:crypto";
33
import * as Cause from "effect/Cause";
44
import * as Clock from "effect/Clock";

0 commit comments

Comments
 (0)