Skip to content

Commit ed6ae26

Browse files
t3dotggclaude
andcommitted
feat(desktop): older nightlies in the update popover show how many days ago they shipped
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent c99587d commit ed6ae26

4 files changed

Lines changed: 46 additions & 4 deletions

File tree

‎apps/desktop/src/updates/releaseNotes.test.ts‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ describe("normalizeDesktopUpdateReleaseNotes", () => {
2828
releaseNotes: [
2929
{
3030
version: "0.0.36-nightly.20260828.1213",
31+
releasedAt: "2026-08-28",
3132
items: [
3233
"fix(opencode): handle child approvals, stops, and model catalogs by @human in #8480",
3334
"fix(web): keep long task drawers usable on small screens by @human in #8313",
@@ -111,6 +112,23 @@ describe("normalizeDesktopUpdateReleaseNotes", () => {
111112
]);
112113
});
113114

115+
it("dates the offered release from the feed and older nightlies by their build day", () => {
116+
const result = normalizeDesktopUpdateReleaseNotes(
117+
[
118+
{ version: "0.0.41-nightly.20260914.1707", note: "- Nightly change 2" },
119+
{ version: "0.0.41-nightly.20260913.1700", note: "- Nightly change 1" },
120+
],
121+
"0.0.41-nightly.20260914.1707",
122+
"nightly",
123+
"2026-09-14T18:30:00.000Z",
124+
);
125+
126+
expect(result.releaseNotes.map(({ releasedAt }) => releasedAt)).toEqual([
127+
"2026-09-14T18:30:00.000Z",
128+
"2026-09-13",
129+
]);
130+
});
131+
114132
it("drops releases from other trains before grouping on nightly", () => {
115133
const releaseNotes = [
116134
{ version: "0.0.41-preview.20260914.1683", note: "- Maintainer test build" },

‎apps/desktop/src/updates/releaseNotes.ts‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,15 @@ function extractReleaseNoteItems(note: string | null | undefined): ExtractedRele
152152
return { items: items.toReversed(), totalItems };
153153
}
154154

155+
// The update feed dates only the offered version; prerelease versions carry their UTC build day.
156+
const PRERELEASE_BUILD_DAY = /-(?:nightly|preview)\.(\d{4})(\d{2})(\d{2})\.\d+$/;
157+
158+
function resolveReleasedAt(version: string, offeredVersion: string, releaseDate?: string) {
159+
if (version === offeredVersion && releaseDate) return releaseDate;
160+
const day = PRERELEASE_BUILD_DAY.exec(version);
161+
return day ? `${day[1]}-${day[2]}-${day[3]}` : undefined;
162+
}
163+
155164
interface NormalizedDesktopUpdateReleaseNotes {
156165
readonly releaseNotes: ReadonlyArray<DesktopUpdateReleaseNote>;
157166
readonly omittedReleaseCount: number;
@@ -175,14 +184,15 @@ export function normalizeDesktopUpdateReleaseNotes(
175184
const normalizedNotes = rawNotes.flatMap((entry) => {
176185
const { items, totalItems, intro, stats } = extractReleaseNoteItems(entry.note);
177186
if (totalItems === 0) return [];
187+
const releasedAt = resolveReleasedAt(entry.version, fallbackVersion, releaseDate);
178188
return [
179189
{
180190
version: entry.version,
181191
items,
182192
totalItems,
183193
...(intro ? { intro } : {}),
184194
...(stats ? { stats } : {}),
185-
...(releaseDate && entry.version === fallbackVersion ? { releasedAt: releaseDate } : {}),
195+
...(releasedAt ? { releasedAt } : {}),
186196
},
187197
];
188198
});

‎apps/web/src/components/sidebar/SidebarUpdateReleaseNotes.tsx‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,18 @@ function keyReleaseNoteItems(items: ReadonlyArray<string>) {
1919
});
2020
}
2121

22+
/** Feed times read "3h ago"; build days from a prerelease version read "today" or "2d ago". */
23+
function formatReleaseAge(releasedAt: string): string {
24+
const day = /^(\d{4})-(\d{2})-(\d{2})$/.exec(releasedAt);
25+
if (!day) return formatRelativeTimeLabel(releasedAt);
26+
const now = new Date();
27+
const today = Date.UTC(now.getUTCFullYear(), now.getUTCMonth(), now.getUTCDate());
28+
const days = Math.round(
29+
(today - Date.UTC(Number(day[1]), Number(day[2]) - 1, Number(day[3]))) / 86_400_000,
30+
);
31+
return days <= 0 ? "today" : `${days}d ago`;
32+
}
33+
2234
function ReleaseLink({
2335
children,
2436
releaseUrl,
@@ -70,7 +82,7 @@ export function SidebarUpdateReleaseNotes({
7082
{state.availableVersion ? (
7183
<div className="mt-0.5 text-xs leading-4 text-muted-foreground">
7284
{releasedAt
73-
? `${state.availableVersion} · ${formatRelativeTimeLabel(releasedAt)}`
85+
? `${state.availableVersion} · ${formatReleaseAge(releasedAt)}`
7486
: state.availableVersion}
7587
</div>
7688
) : null}
@@ -93,7 +105,9 @@ export function SidebarUpdateReleaseNotes({
93105
<section className={index > 0 ? "mt-4" : undefined} key={releaseNote.version}>
94106
{index > 0 ? (
95107
<h3 className="mb-1 text-xs leading-4 font-medium text-muted-foreground">
96-
{releaseNote.version}
108+
{releaseNote.releasedAt
109+
? `${releaseNote.version} · ${formatReleaseAge(releaseNote.releasedAt)}`
110+
: releaseNote.version}
97111
</h3>
98112
) : null}
99113
<p className="break-words text-xs leading-5 text-popover-foreground">

‎packages/contracts/src/ipc.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ export interface DesktopUpdateReleaseNote {
288288
version: string;
289289
items: ReadonlyArray<string>;
290290
totalItems: number;
291-
/** ISO time the update feed reports for this version. Only the offered version has one. */
291+
/** ISO time from the update feed for the offered version, else `YYYY-MM-DD` from a prerelease version. */
292292
releasedAt?: string;
293293
/** Generated summaries only: the highlights paragraph. `items` then holds the fixes. */
294294
intro?: string;

0 commit comments

Comments
 (0)