Skip to content

Commit ed05c0e

Browse files
fix(server): preview drag moves the mouse during the drag (#36096)
1 parent 74573fc commit ed05c0e

2 files changed

Lines changed: 33 additions & 1 deletion

File tree

‎apps/server/src/preview/ServerBrowserPage.test.ts‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -577,6 +577,37 @@ describe("server browser drag", () => {
577577
process.off("unhandledRejection", onUnhandled);
578578
}
579579
});
580+
581+
it("moves the mouse after dragstart, so pages that track a drag with mousemove see it", async () => {
582+
const browser = await chromium.launch({ headless: true });
583+
try {
584+
const page = await browser.newPage();
585+
await page.setContent(`
586+
<div style="display:flex;gap:40px">
587+
<div id="source" draggable="true" style="width:200px;height:120px">source</div>
588+
<div id="target" style="width:200px;height:120px">target</div>
589+
</div>
590+
<script>
591+
window.events = [];
592+
let dragging = false;
593+
source.addEventListener("dragstart", (event) => {
594+
event.preventDefault();
595+
dragging = true;
596+
events.push("dragstart");
597+
});
598+
addEventListener("mousemove", () => dragging && events.push("mousemove"));
599+
addEventListener("mouseup", () => events.push("mouseup"));
600+
</script>`);
601+
602+
await ServerBrowserPage.drag(page, { source: "#source", target: "#target" });
603+
604+
const events = (await page.evaluate("window.events")) as Array<string>;
605+
expect(events.slice(0, 2)).toEqual(["dragstart", "mousemove"]);
606+
expect(events.at(-1)).toBe("mouseup");
607+
} finally {
608+
await browser.close();
609+
}
610+
});
580611
});
581612

582613
describe("server browser evaluate", () => {

‎apps/server/src/preview/ServerBrowserPage.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,8 @@ export const drag = async (
888888
const target = targetLocator(page, { locator: input.target })!;
889889
await pointer(await targetPoint(page, source, {}, timeout), "move");
890890
// Observe drag rejection immediately; an unhandled rejection during cursor movement exits the server.
891-
const dragFailure = source.dragTo(target, { timeout }).then(
891+
// Chromium delivers a single move before dragstart; steps give the page mousemoves during the drag.
892+
const dragFailure = source.dragTo(target, { timeout, steps: 5 }).then(
892893
() => null,
893894
(error: unknown) => ({ error }),
894895
);

0 commit comments

Comments
 (0)