Skip to content

Commit ec0b501

Browse files
fix(settings): ignore overrides left undefined by a forward-compatible decode
Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent 763462d commit ec0b501

2 files changed

Lines changed: 16 additions & 0 deletions

File tree

‎packages/shared/src/projectSettings.test.ts‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,19 @@ describe("resolveProjectSettings", () => {
3030
);
3131
});
3232

33+
it("ignores an override left undefined by a forward-compatible decode", () => {
34+
const resolved = resolveProjectSettings(
35+
{
36+
...DEFAULT_SERVER_SETTINGS,
37+
defaultRuntimeMode: "full-access",
38+
projectSettingsOverrides: { [projectId]: { defaultRuntimeMode: undefined } as never },
39+
},
40+
projectId,
41+
);
42+
expect(resolved.settings.defaultRuntimeMode).toBe("full-access");
43+
expect(resolved.sources.defaultRuntimeMode).toBe("environment");
44+
});
45+
3346
it("treats a null project like an absent one before the shell snapshot arrives", () => {
3447
// The mobile new-task flow resolves settings while its selected project is
3548
// still null; reading the aggregate's legacy fields off null crashed launch.

‎packages/shared/src/projectSettings.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,9 @@ function resolveProjectOverrides(
146146
for (const key of PROJECT_SCOPED_SERVER_SETTING_KEYS) {
147147
if (!Object.hasOwn(overrides, key)) continue;
148148
const value = overrides[key];
149+
// A forward-compatible decode leaves an unknown value as a present
150+
// undefined; that is not an override.
151+
if (value === undefined) continue;
149152
// A model on a disabled provider falls back to the environment, like the
150153
// environment-level guards do for these keys.
151154
if (

0 commit comments

Comments
 (0)