Repository navigation
Commit eb7f45e
fix(acp): agents get T3's runtime notes once per session, not on every message
The ACP adapter appended the runtime_info and pull request linking block to
every non-slash prompt. ACP agents keep their own history, so the block piled
up, one copy per user message.
Remember per session the block last delivered and resend it only when its
text changes (a model switch), after compaction, or in a new or replacement
session. Delivery is recorded after a successful session/prompt, next to the
existing instruction state. Replay fixtures expect the block until a prompt
in the session succeeds, matching the adapter.
Fixes #24185
Co-authored-by: Mariusz Mazur <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 6d450a4 commit eb7f45e
3 files changed
Lines changed: 71 additions & 18 deletions
File tree
- apps/server/src/orchestration-v2
- Adapters
- testkit
- packages/provider-acp/src/server
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
416 | 416 | | |
417 | 417 | | |
418 | 418 | | |
| 419 | + | |
419 | 420 | | |
420 | 421 | | |
421 | 422 | | |
| |||
959 | 960 | | |
960 | 961 | | |
961 | 962 | | |
| 963 | + | |
962 | 964 | | |
963 | 965 | | |
964 | 966 | | |
| |||
969 | 971 | | |
970 | 972 | | |
971 | 973 | | |
| 974 | + | |
972 | 975 | | |
973 | 976 | | |
974 | 977 | | |
| |||
1006 | 1009 | | |
1007 | 1010 | | |
1008 | 1011 | | |
| 1012 | + | |
1009 | 1013 | | |
1010 | 1014 | | |
1011 | 1015 | | |
1012 | 1016 | | |
1013 | 1017 | | |
1014 | | - | |
1015 | | - | |
1016 | | - | |
1017 | | - | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
1018 | 1021 | | |
1019 | 1022 | | |
1020 | 1023 | | |
| |||
1031 | 1034 | | |
1032 | 1035 | | |
1033 | 1036 | | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
1034 | 1043 | | |
1035 | 1044 | | |
1036 | 1045 | | |
| |||
1054 | 1063 | | |
1055 | 1064 | | |
1056 | 1065 | | |
1057 | | - | |
| 1066 | + | |
1058 | 1067 | | |
1059 | 1068 | | |
1060 | 1069 | | |
| |||
1069 | 1078 | | |
1070 | 1079 | | |
1071 | 1080 | | |
1072 | | - | |
1073 | | - | |
1074 | | - | |
1075 | | - | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
1076 | 1084 | | |
1077 | 1085 | | |
1078 | 1086 | | |
1079 | | - | |
| 1087 | + | |
1080 | 1088 | | |
1081 | 1089 | | |
1082 | 1090 | | |
| |||
3285 | 3293 | | |
3286 | 3294 | | |
3287 | 3295 | | |
| 3296 | + | |
3288 | 3297 | | |
3289 | 3298 | | |
3290 | 3299 | | |
| 3300 | + | |
3291 | 3301 | | |
3292 | 3302 | | |
3293 | 3303 | | |
| |||
3419 | 3429 | | |
3420 | 3430 | | |
3421 | 3431 | | |
| 3432 | + | |
| 3433 | + | |
| 3434 | + | |
| 3435 | + | |
| 3436 | + | |
| 3437 | + | |
| 3438 | + | |
| 3439 | + | |
| 3440 | + | |
3422 | 3441 | | |
3423 | 3442 | | |
3424 | 3443 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
25 | 43 | | |
26 | 44 | | |
27 | 45 | | |
| |||
45 | 63 | | |
46 | 64 | | |
47 | 65 | | |
| 66 | + | |
| 67 | + | |
48 | 68 | | |
49 | 69 | | |
50 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1594 | 1594 | | |
1595 | 1595 | | |
1596 | 1596 | | |
| 1597 | + | |
1597 | 1598 | | |
1598 | 1599 | | |
1599 | 1600 | | |
| |||
6574 | 6575 | | |
6575 | 6576 | | |
6576 | 6577 | | |
| 6578 | + | |
6577 | 6579 | | |
6578 | 6580 | | |
6579 | 6581 | | |
| |||
7279 | 7281 | | |
7280 | 7282 | | |
7281 | 7283 | | |
7282 | | - | |
7283 | | - | |
7284 | | - | |
7285 | | - | |
7286 | | - | |
7287 | | - | |
7288 | | - | |
7289 | | - | |
| 7284 | + | |
| 7285 | + | |
| 7286 | + | |
| 7287 | + | |
| 7288 | + | |
| 7289 | + | |
| 7290 | + | |
| 7291 | + | |
| 7292 | + | |
| 7293 | + | |
| 7294 | + | |
7290 | 7295 | | |
7291 | 7296 | | |
7292 | 7297 | | |
7293 | 7298 | | |
| 7299 | + | |
7294 | 7300 | | |
7295 | 7301 | | |
7296 | 7302 | | |
| |||
7603 | 7609 | | |
7604 | 7610 | | |
7605 | 7611 | | |
| 7612 | + | |
| 7613 | + | |
| 7614 | + | |
| 7615 | + | |
| 7616 | + | |
| 7617 | + | |
| 7618 | + | |
| 7619 | + | |
7606 | 7620 | | |
7607 | 7621 | | |
7608 | 7622 | | |
| |||
0 commit comments