Skip to content

Commit eaa177b

Browse files
juliusmarmingePixPMusic
authored andcommitted
fix(mobile): preserve per-sheet bar placement after main merge
1 parent 5675733 commit eaa177b

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎apps/mobile/src/Stack.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -902,8 +902,8 @@ const RootStackConfig = createWorkspaceStackNavigator({
902902
screen: ThreadPullRequestsSheet,
903903
linking: `${THREAD_LINKING_PREFIX}/pull-requests`,
904904
options: {
905-
...FORM_SHEET_PRESENTATION_OPTIONS,
906-
sheetAllowedDetents: [0.55, 0.92],
905+
...HORIZONTAL_FORM_SHEET_OPTIONS,
906+
sheetAllowedDetents: formSheetDetents(0.55),
907907
sheetGrabberVisible: true,
908908
},
909909
}),
@@ -1009,6 +1009,7 @@ const RootStackConfig = createWorkspaceStackNavigator({
10091009
),
10101010
options: {
10111011
...NESTED_NAVIGATOR_OPTIONS,
1012+
sheetPrefersHorizontalBars: true,
10121013
gestureEnabled: true,
10131014
headerShown: false,
10141015
},
@@ -1066,8 +1067,7 @@ export const RootStack = RootStackConfig.with(function AdaptiveRootStack({ Navig
10661067
return usesWorkspaceFlowScreens
10671068
? { presentation: "card" }
10681069
: {
1069-
...HORIZONTAL_FORM_SHEET_OPTIONS,
1070-
sheetPrefersHorizontalBars: route.name !== "SettingsSheet",
1070+
presentation: "formSheet",
10711071
sheetAllowedDetents: [1],
10721072
sheetGrabberVisible: true,
10731073
};

‎apps/mobile/src/components/ui/Sheet.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export function Sheet(props: SheetProps) {
2222
return (
2323
<FormSheet
2424
isOpen={isOpen}
25-
detents={formSheetDetents(0.5, 0.9)}
25+
detents={props.prefersHorizontalBars ? formSheetDetents(0.5, 0.9) : [0.5, 0.9]}
2626
prefersGrabberVisible
2727
prefersHorizontalBars={props.prefersHorizontalBars}
2828
nativeContainerStyle={containerStyle}

0 commit comments

Comments
 (0)