Skip to content

Commit e9a00e1

Browse files
committed
fix(muse): recover from unavailable session views
Reject projectionUnavailable before turn/start so existing session recovery can open a fresh native session with the conversation handoff. Implemented with OpenAI GPT-6 via the Codex harness.
1 parent 6577c6b commit e9a00e1

3 files changed

Lines changed: 34 additions & 7 deletions

File tree

‎packages/provider-muse/src/server/adapter.test.ts‎

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -850,16 +850,33 @@ describe("MuseAdapterV2", () => {
850850
}).pipe(Effect.provide(testLayer)),
851851
);
852852

853-
it.effect(
854-
"closes a newly opened host when native session registration returns another identity",
855-
() =>
853+
it.effect.each([
854+
{
855+
reason: "another identity",
856+
method: "session/start",
857+
sessionId: "unexpected-session",
858+
initialNativeThreadId: undefined,
859+
history: { items: [] },
860+
},
861+
{
862+
reason: "an unavailable projection",
863+
method: "session/resume",
864+
sessionId: "saved-session",
865+
initialNativeThreadId: "saved-session",
866+
history: { items: null, mode: "none", noneReason: "projectionUnavailable" },
867+
},
868+
])(
869+
"closes a newly opened host when native session registration returns $reason",
870+
({ method, sessionId, initialNativeThreadId, history }) =>
856871
Effect.gen(function* () {
857872
const fake = yield* makeFakeMuse();
858-
fake.queueResponse("session/start", {
859-
session: { sessionId: "unexpected-session", modelId: MODEL, activeTurnId: null },
860-
history: { items: [] },
873+
fake.queueResponse(method, {
874+
session: { sessionId, modelId: MODEL, activeTurnId: null },
875+
history,
861876
});
862-
const result = yield* makeHarness(fake).pipe(Effect.exit);
877+
const result = yield* makeHarness(fake, INSTANCE_ID, initialNativeThreadId).pipe(
878+
Effect.exit,
879+
);
863880
assert.strictEqual(result._tag, "Failure");
864881
yield* Effect.promise(() => fake.host.exited);
865882
assert.strictEqual(fake.closeCount(), 1);
@@ -1441,6 +1458,11 @@ describe("MuseAdapterV2", () => {
14411458
text: "Previous answer",
14421459
};
14431460
fake.setHistory([nativeItem]);
1461+
fake.queueResponse("session/resume", {
1462+
session: { sessionId: "saved-session", modelId: MODEL, activeTurnId: null },
1463+
viewCursor: "",
1464+
history: { items: null, mode: "none", noneReason: "excluded" },
1465+
});
14441466
const harness = yield* makeHarness(fake, INSTANCE_ID, "saved-session");
14451467
const resumed = yield* fake.takeCall("session/resume");
14461468
assert.strictEqual(resumed.params.sessionId, "saved-session");

‎packages/provider-muse/src/server/adapter.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1879,6 +1879,10 @@ export const makeMuseAdapterV2 = Effect.fn("makeMuseAdapterV2")(function* (
18791879
);
18801880
if (result.session.sessionId !== nativeSessionId)
18811881
return yield* protocolError("Muse returned a different session identity");
1882+
if (result.history?.noneReason === "projectionUnavailable")
1883+
return yield* protocolError(
1884+
"Muse cannot stream this session because its live view is unavailable",
1885+
);
18821886
if (requestedId)
18831887
yield* request("session/setApprovalMode", {
18841888
mode: museApprovalMode(args.runtimePolicy.runtimeMode),

‎packages/provider-muse/src/server/protocol.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export const MuseSessionResult = Schema.Struct({
7070
history: Schema.optional(
7171
Schema.Struct({
7272
items: Schema.NullOr(Schema.Array(MuseItem)),
73+
noneReason: Schema.optional(Schema.String),
7374
snapshot: Schema.optional(
7475
Schema.NullOr(
7576
Schema.Struct({

0 commit comments

Comments
 (0)