@@ -171,7 +171,7 @@ describe("CDP relay extra sessions", () => {
171171} ) ;
172172
173173describe ( "CDP relay downloads" , ( ) => {
174- it ( "applies the server's download directory and reports downloads on the root session " , async ( ) => {
174+ it ( "captures preview downloads without changing the default browser context " , async ( ) => {
175175 const send = vi . fn ( async ( ) => ( { } ) ) ;
176176 const directories : Array < string | null > = [ ] ;
177177 const written : Array < Record < string , unknown > > = [ ] ;
@@ -194,17 +194,110 @@ describe("CDP relay downloads", () => {
194194 ) ;
195195 await settle ( ) ;
196196 expect ( directories ) . toEqual ( [ "/srv/artifacts" ] ) ;
197- expect ( send ) . toHaveBeenCalledWith (
198- "Browser.setDownloadBehavior" ,
199- { behavior : "allowAndName" , downloadPath : "/srv/artifacts" , eventsEnabled : true } ,
200- undefined ,
201- ) ;
197+ expect ( send . mock . calls ) . toEqual ( [
198+ [ "Page.setDownloadBehavior" , { behavior : "default" } , undefined ] ,
199+ ] ) ;
202200 written . length = 0 ;
203- relay . event ( "Browser.downloadWillBegin" , { guid : "g1" , suggestedFilename : "r.csv" } , "" ) ;
201+ relay . event ( "Page.downloadWillBegin" , { guid : "g1" , suggestedFilename : "r.csv" } , "" ) ;
202+ relay . event ( "Page.downloadProgress" , { guid : "g1" , state : "completed" } , "" ) ;
204203 expect ( written ) . toEqual ( [
205204 { method : "Browser.downloadWillBegin" , params : { guid : "g1" , suggestedFilename : "r.csv" } } ,
205+ { method : "Browser.downloadProgress" , params : { guid : "g1" , state : "completed" } } ,
206206 ] ) ;
207207 } ) ;
208+
209+ it ( "keeps denial scoped to the preview and restores Electron's save handling when allowed" , async ( ) => {
210+ const send = vi . fn ( async ( ) => ( { } ) ) ;
211+ const directories : Array < string | null > = [ ] ;
212+ const relay = makeRelay (
213+ makeTarget ( send , ( directory ) => directories . push ( directory ) ) ,
214+ ( ) => { } ,
215+ ) ;
216+ for ( const [ id , behavior ] of [ "deny" , "allowAndName" ] . entries ( ) ) {
217+ relay . receive (
218+ JSON . stringify ( {
219+ id,
220+ method : "Browser.setDownloadBehavior" ,
221+ params : { behavior, downloadPath : "/srv/artifacts" } ,
222+ } ) ,
223+ ) ;
224+ await settle ( ) ;
225+ }
226+ expect ( directories ) . toEqual ( [ null , "/srv/artifacts" ] ) ;
227+ expect ( send . mock . calls ) . toEqual ( [
228+ [ "Page.setDownloadBehavior" , { behavior : "deny" } , undefined ] ,
229+ [ "Page.setDownloadBehavior" , { behavior : "default" } , undefined ] ,
230+ ] ) ;
231+ } ) ;
232+
233+ it ( "does not publish download events when the connection has disabled them" , async ( ) => {
234+ const written : Array < Record < string , unknown > > = [ ] ;
235+ const relay = makeRelay ( makeTarget ( vi . fn ( async ( ) => ( { } ) ) ) , ( raw ) =>
236+ written . push ( JSON . parse ( raw ) ) ,
237+ ) ;
238+ relay . receive ( JSON . stringify ( { id : 1 , method : "Target.setAutoAttach" , params : { } } ) ) ;
239+ relay . receive (
240+ JSON . stringify ( {
241+ id : 2 ,
242+ method : "Browser.setDownloadBehavior" ,
243+ params : { behavior : "allowAndName" , downloadPath : "/srv/artifacts" , eventsEnabled : false } ,
244+ } ) ,
245+ ) ;
246+ await settle ( ) ;
247+ written . length = 0 ;
248+ relay . event ( "Page.downloadWillBegin" , { guid : "g1" } , "" ) ;
249+ relay . event ( "Page.downloadProgress" , { guid : "g1" , state : "completed" } , "" ) ;
250+ expect ( written ) . toEqual ( [ ] ) ;
251+ } ) ;
252+
253+ it . each ( [ false , true ] ) (
254+ "keeps the previous download configuration (events enabled: %s) when configuration fails" ,
255+ async ( enabled ) => {
256+ const send = vi
257+ . fn ( async ( ) => ( { } ) )
258+ . mockResolvedValueOnce ( { } )
259+ . mockRejectedValueOnce ( new Error ( "Page command rejected" ) ) ;
260+ const written : Array < Record < string , unknown > > = [ ] ;
261+ let directory : string | null = null ;
262+ const relay = makeRelay (
263+ makeTarget ( send , ( value ) => {
264+ directory = value ;
265+ } ) ,
266+ ( raw ) => written . push ( JSON . parse ( raw ) ) ,
267+ ) ;
268+ relay . receive ( JSON . stringify ( { id : 1 , method : "Target.setAutoAttach" , params : { } } ) ) ;
269+ for ( const [ id , eventsEnabled ] of [ enabled , ! enabled ] . entries ( ) ) {
270+ relay . receive (
271+ JSON . stringify ( {
272+ id : id + 2 ,
273+ method : "Browser.setDownloadBehavior" ,
274+ params : {
275+ behavior : id === 1 && enabled ? "deny" : "allowAndName" ,
276+ downloadPath : id === 0 ? "/srv/artifacts" : "/srv/new-artifacts" ,
277+ eventsEnabled,
278+ } ,
279+ } ) ,
280+ ) ;
281+ await settle ( ) ;
282+ }
283+ expect ( written ) . toContainEqual ( {
284+ id : 3 ,
285+ error : { code : - 32000 , message : "Page command rejected" } ,
286+ } ) ;
287+ expect ( directory ) . toBe ( "/srv/artifacts" ) ;
288+ written . length = 0 ;
289+ relay . event ( "Page.downloadWillBegin" , { guid : "g1" } , "" ) ;
290+ relay . event ( "Page.downloadProgress" , { guid : "g1" , state : "completed" } , "" ) ;
291+ expect ( written ) . toEqual (
292+ enabled
293+ ? [
294+ { method : "Browser.downloadWillBegin" , params : { guid : "g1" } } ,
295+ { method : "Browser.downloadProgress" , params : { guid : "g1" , state : "completed" } } ,
296+ ]
297+ : [ ] ,
298+ ) ;
299+ } ,
300+ ) ;
208301} ) ;
209302
210303describe ( "CDP relay payload budget" , ( ) => {
0 commit comments