Skip to content

Commit e67b115

Browse files
PR Batch Testerclaude
andcommitted
fix(desktop): fit the shipped locale paks in the Windows file budget
Electron's Windows build has 55 locale paks. Shipping all of them pushes the unpacked app past the 80-file budget, which fails the release. Main's payload is at most 80 files, so 54 more stay under 140. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent dc4d05a commit e67b115

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎docs/operations/release.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ break:
502502
`node_modules/` with the Linux node-pty binary, and must not carry a loose
503503
server bundle (`bin.mjs`).
504504
- The external Windows resource monitor is absent.
505-
- The unpacked Windows application contains more than 80 files.
505+
- The unpacked Windows application contains more than 140 files.
506506

507507
Cross-architecture Windows builds retain every structural and extracted-sidecar
508508
check, but skip executing the target Electron binary. A same-architecture build

‎scripts/build-desktop-artifact.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ it.layer(NodeServices.layer)("build-desktop-artifact", (it) => {
523523
),
524524
);
525525

526-
it.effect("ships every Chromium locale so web pages follow the OS language", () =>
526+
it.effect("leaves electronLanguages unset so every Chromium locale pak ships", () =>
527527
Effect.gen(function* () {
528528
for (const [platform, target] of [
529529
["mac", "dmg"],

‎scripts/build-desktop-artifact.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1073,7 +1073,9 @@ export function resolveWindowsServerAsarIgnoreGlobs(arch: typeof BuildArch.Type)
10731073
];
10741074
}
10751075

1076-
export const WINDOWS_PACKAGED_PAYLOAD_FILE_LIMIT = 80;
1076+
// Catches loose dependency trees, which run to hundreds of files. Chromium's
1077+
// locale paks alone are 55 files.
1078+
export const WINDOWS_PACKAGED_PAYLOAD_FILE_LIMIT = 140;
10771079
export const WINDOWS_SERVER_RESOURCE_SOURCE_DIR = "apps/desktop/prod-resources/windows-server";
10781080
export const WINDOWS_SERVER_EXTRA_RESOURCES = [
10791081
{

0 commit comments

Comments
 (0)