Repository navigation
Commit e5cb117
fix(mobile): returning to a tab clears its old detail instead of crashing
A tab switch pops the workspace to its list, so the tab you return to
drops the detail it was showing. Its column attaches the empty
placeholder and removes the old screen in one commit, but Reanimated
held the removal for exiting animations inside the screen, because it
only exempts legacy Screens components. Screens pushed the placeholder
over the still-mounted pull request, then popped a screen that was no
longer on top: debug builds crashed with "Attempt to pop non-top
screen", and release builds would pop the placeholder and leave the
stale pull request showing. This affects iPad and iPhone Duo columns,
folded or not.
Reanimated now treats Screens v5 stack, split and tab screens like
legacy screens, so their removal lands in the same mount as the rest of
the commit.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 017af25 commit e5cb117
3 files changed
Lines changed: 24 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
349 | 349 | | |
350 | 350 | | |
351 | 351 | | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
352 | 355 | | |
353 | 356 | | |
354 | 357 | | |
| |||
0 commit comments