Skip to content

Commit e576e64

Browse files
committed
test(server): a changed secret provider retries unreadable instance secrets
Signed-off-by: Yordis Prieto <[email protected]>
1 parent 5915cb9 commit e576e64

2 files changed

Lines changed: 45 additions & 1 deletion

File tree

‎apps/server/src/provider/ProviderInstanceRegistryHydration.test.ts‎

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,27 @@ import {
33
ProjectId,
44
ProviderDriverKind,
55
ProviderInstanceId,
6+
SecretProviderId,
67
type ServerSettings,
78
} from "@t3tools/contracts";
89
import * as NodeServices from "@effect/platform-node/NodeServices";
910
import { it as effectIt } from "@effect/vitest";
1011
import * as Effect from "effect/Effect";
12+
import * as Deferred from "effect/Deferred";
1113
import * as Layer from "effect/Layer";
14+
import * as Queue from "effect/Queue";
15+
import * as Stream from "effect/Stream";
1216
import { describe, expect, it } from "vite-plus/test";
1317

1418
import * as ServerConfig from "../config.ts";
1519
import { ServerSettingsService } from "../serverSettings.ts";
1620
import {
1721
DEV_REPLAY_INSTANCE_ID,
1822
deriveProviderInstanceConfigMap,
23+
layerSettingsWatcher,
1924
seedDevReplayInstance,
2025
} from "./ProviderInstanceRegistryHydration.ts";
26+
import { ProviderInstanceRegistryMutator } from "./ProviderInstanceRegistryMutator.ts";
2127

2228
const projectId = ProjectId.make("project-a");
2329
const instanceId = ProviderInstanceId.make("codex_work");
@@ -141,3 +147,41 @@ describe("seedDevReplayInstance", () => {
141147
),
142148
);
143149
});
150+
151+
describe("layerSettingsWatcher", () => {
152+
effectIt.effect("retries unreadable secrets when a secret provider changes", () =>
153+
Effect.gen(function* () {
154+
const settings = yield* ServerSettingsService;
155+
const changes = yield* Queue.unbounded<ServerSettings>();
156+
const calls: Array<"reconcile" | "reloadSecrets"> = [];
157+
const reconciled = yield* Deferred.make<void>();
158+
let reconciles = 0;
159+
const mutator = Layer.succeed(ProviderInstanceRegistryMutator, {
160+
reconcile: () =>
161+
Effect.suspend(() => {
162+
calls.push("reconcile");
163+
return ++reconciles === 2 ? Deferred.succeed(reconciled, undefined) : Effect.void;
164+
}),
165+
reloadSecrets: () => Effect.sync(() => void calls.push("reloadSecrets")),
166+
});
167+
yield* Layer.build(
168+
layerSettingsWatcher(Stream.fromQueue(changes)).pipe(Layer.provide(mutator)),
169+
);
170+
171+
const next = yield* settings.updateSettings({
172+
secretProviders: {
173+
[SecretProviderId.make("personal")]: {
174+
kind: "one_password",
175+
label: "Personal",
176+
config: { account: "my" },
177+
},
178+
},
179+
});
180+
yield* Queue.offer(changes, next);
181+
yield* Queue.offer(changes, next);
182+
yield* Deferred.await(reconciled);
183+
184+
expect(calls).toEqual(["reconcile", "reloadSecrets", "reconcile"]);
185+
}).pipe(Effect.scoped, Effect.provide(ServerSettingsService.layerTest())),
186+
);
187+
});

‎apps/server/src/provider/ProviderInstanceRegistryHydration.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export const seedDevReplayInstance = Effect.fn(
122122
});
123123
});
124124

125-
const layerSettingsWatcher = (settingsChanges: Stream.Stream<ServerSettings>) =>
125+
export const layerSettingsWatcher = (settingsChanges: Stream.Stream<ServerSettings>) =>
126126
Layer.effectDiscard(
127127
Effect.gen(function* () {
128128
const mutator = yield* ProviderInstanceRegistryMutator.ProviderInstanceRegistryMutator;

0 commit comments

Comments
 (0)