Skip to content

Commit e4239ca

Browse files
PR Batch Testerclaude
andcommitted
fix(web): the welcome list reads Off for a switched-off computer that needs an update
Main's new rule in the welcome list copied Settings' old check, which assumed an incompatible computer was always switched off. With the switch now meaning only the user's choice, Off wins as it does in Settings. Also updates main's pairing test setup to the new compatibility state. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 992118c commit e4239ca

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

‎apps/web/src/components/onboarding/WelcomeWizard.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ function ConnectionStep({
370370
</span>
371371
<span className="shrink-0 text-xs text-muted-foreground">
372372
{/* Same rule as Settings: a switched-off computer reads Off, not Not connected. */}
373-
{!environment.entry.enabled && environment.connection.phase !== "unsupported"
373+
{!environment.entry.enabled
374374
? "Off"
375375
: presentSavedCloudEnvironmentConnection(environment.connection).buttonLabel}
376376
</span>

‎packages/client-runtime/src/connection/onboarding.test.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,10 @@ describe("connection onboarding", () => {
370370
);
371371
yield* registry.setCompatibility(PAIRED_ENVIRONMENT_ID, UNSUPPORTED_ERROR);
372372
const before = yield* SubscriptionRef.get(registry.entries);
373-
expect(before.get(PAIRED_ENVIRONMENT_ID)?.enabled).toBe(false);
373+
expect(before.get(PAIRED_ENVIRONMENT_ID)).toMatchObject({
374+
enabled: true,
375+
unsupportedReason: UNSUPPORTED_ERROR.message,
376+
});
374377

375378
const environmentId = yield* onboarding.registerPairing(PAIRING_INPUT);
376379

0 commit comments

Comments
 (0)