Skip to content

Commit e2729a6

Browse files
Mezzleclaude
andcommitted
fix(web): scheduled tasks can pick effort and Fast like the composer
The scheduled task editor's model picker only chose a model, so Codex's priority tier, reasoning effort and other provider options could not be set for a task, though a run already uses whatever options the task stores. The editor now docks the composer's own effort column and speed footer into the picker, shows the effort and Fast in the trigger, and keeps the full model selection, options included, in the draft. The footer's permissions menu is now optional, since tasks keep their own runtime mode. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 8b44f42 commit e2729a6

6 files changed

Lines changed: 258 additions & 42 deletions

File tree

‎apps/server/src/scheduledTasks/ScheduledTaskService.test.ts‎

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99
ScheduledTaskError,
1010
ScheduledTaskId,
1111
ThreadId,
12+
type ModelSelection,
1213
} from "@t3tools/contracts";
1314
import * as DateTime from "effect/DateTime";
1415
import * as Effect from "effect/Effect";
@@ -618,3 +619,58 @@ it.effect("a run interrupted right after it reserves the task does not block the
618619
}).pipe(Effect.provide(layer));
619620
}).pipe(Effect.provide(SqlitePersistence.layerMemory)),
620621
);
622+
623+
it.effect("a run launches with the stored model options, such as Codex's priority tier", () =>
624+
Effect.gen(function* () {
625+
const launched = yield* Ref.make<Array<ModelSelection>>([]);
626+
const layer = ScheduledTaskService.layer.pipe(
627+
Layer.provide(
628+
Layer.mergeAll(
629+
ManagedPolicy.layerTest(),
630+
Layer.mock(ThreadLaunchService.ThreadLaunchService)({
631+
launch: (input) =>
632+
Ref.update(launched, (all) => [...all, input.modelSelection]).pipe(
633+
Effect.as({ threadId: ThreadId.make("thread:launched"), resumed: false } as never),
634+
),
635+
}),
636+
Layer.mock(ThreadManagementService.ThreadManagementService)({}),
637+
Layer.mock(SecretRequests.SecretRequests)({}),
638+
Layer.mock(ManagedProjectFolders.ManagedProjectFolders)({
639+
namedProjectsRoot: "/projects",
640+
isScratchProject: () => Effect.succeed(false),
641+
}),
642+
NodeCrypto.layer,
643+
Layer.succeed(Scheduler.Scheduler, { register: () => Effect.void }),
644+
),
645+
),
646+
);
647+
const modelSelection: ModelSelection = {
648+
instanceId: ProviderInstanceId.make("codex"),
649+
model: "gpt-6.1-terra",
650+
options: [
651+
{ id: "reasoningEffort", value: "low" },
652+
{ id: "serviceTier", value: "priority" },
653+
],
654+
};
655+
yield* Effect.gen(function* () {
656+
const service = yield* ScheduledTaskService.ScheduledTaskService;
657+
const { task } = yield* service.upsert({
658+
id: ScheduledTaskId.make("task:priority-tier"),
659+
title: "Dispatch",
660+
prompt: "Dispatch the issue",
661+
enabled: true,
662+
schedule: { type: "interval", everyMs: 60_000 },
663+
projectId: ProjectId.make("project:test"),
664+
workspaceStrategy: { type: "root" },
665+
modelSelection,
666+
runtimeMode: "full-access",
667+
interactionMode: "default",
668+
});
669+
670+
const stored = (yield* service.list()).tasks.find((entry) => entry.id === task.id);
671+
assert.deepEqual(stored?.modelSelection, modelSelection);
672+
yield* service.runNow({ id: task.id });
673+
assert.deepEqual(yield* Ref.get(launched), [modelSelection]);
674+
}).pipe(Effect.provide(layer));
675+
}).pipe(Effect.provide(SqlitePersistence.layerMemory)),
676+
);

‎apps/web/src/components/chat/ComposerControlsBar.tsx‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,11 @@ export function ComposerControlsBar(props: {
231231
footer={
232232
<ComposerPickerFooter
233233
traits={traitsInput}
234-
runtimeMode={compatibleRuntimeMode}
235-
runtimeModeOptions={compatibleRuntimeModeOptions}
236-
onRuntimeModeChange={handleRuntimeModeChange}
234+
permissions={{
235+
runtimeMode: compatibleRuntimeMode,
236+
runtimeModeOptions: compatibleRuntimeModeOptions,
237+
onRuntimeModeChange: handleRuntimeModeChange,
238+
}}
237239
/>
238240
}
239241
terminalOpen={terminalOpen}

‎apps/web/src/components/chat/ComposerModelEffort.tsx‎

Lines changed: 26 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -637,21 +637,38 @@ function PermissionsMenu(props: {
637637
);
638638
}
639639

640-
/** The model picker's footer: speed stays one click away, permissions sit one menu deeper. */
640+
/**
641+
* The model picker's footer: speed stays one click away, permissions sit one menu deeper.
642+
* Without permissions (scheduled tasks keep their own), a model with no speed has no footer.
643+
*/
641644
export function ComposerPickerFooter(props: {
642645
traits: TraitsSelectionInput | null;
643-
runtimeMode: RuntimeMode;
644-
runtimeModeOptions: ReadonlyArray<RuntimeModeOption>;
645-
onRuntimeModeChange: (mode: RuntimeMode) => void;
646+
permissions?: {
647+
runtimeMode: RuntimeMode;
648+
runtimeModeOptions: ReadonlyArray<RuntimeModeOption>;
649+
onRuntimeModeChange: (mode: RuntimeMode) => void;
650+
};
646651
}) {
652+
const visibility = props.traits ? getTraitsSectionVisibility(props.traits) : null;
653+
const speed =
654+
props.traits && visibility && !visibility.modelIsUnavailable
655+
? splitSpeed(
656+
props.traits.provider,
657+
visibility.selectDescriptors,
658+
visibility.booleanDescriptors,
659+
)
660+
: null;
661+
if (!speed?.speedSelect && !speed?.fastToggle && !props.permissions) return null;
647662
return (
648663
<div className="flex flex-wrap items-center gap-2 border-t border-border/70 bg-muted/40 px-3 py-2">
649664
{props.traits ? <SpeedControl traits={props.traits} /> : null}
650-
<PermissionsMenu
651-
runtimeMode={props.runtimeMode}
652-
options={props.runtimeModeOptions}
653-
onChange={props.onRuntimeModeChange}
654-
/>
665+
{props.permissions ? (
666+
<PermissionsMenu
667+
runtimeMode={props.permissions.runtimeMode}
668+
options={props.permissions.runtimeModeOptions}
669+
onChange={props.permissions.onRuntimeModeChange}
670+
/>
671+
) : null}
655672
</div>
656673
);
657674
}

‎apps/web/src/components/settings/ScheduledTasksSettings.browser.test.tsx‎

Lines changed: 109 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,15 @@ import {
44
DEFAULT_UNIFIED_SETTINGS,
55
EnvironmentId,
66
ProjectId,
7+
ProviderDriverKind,
78
ProviderInstanceId,
89
ScheduledTaskId,
910
ThreadId,
1011
type ScheduledTask,
12+
type ScheduledTaskUpsertInput,
13+
type ServerProvider,
1114
} from "@t3tools/contracts";
15+
import { createModelCapabilities } from "@t3tools/shared/model";
1216
import { describe, expect, it, vi } from "vite-plus/test";
1317
import { page, userEvent } from "vite-plus/test/browser";
1418

@@ -47,14 +51,66 @@ const threadFamilyRead = {
4751
threads: [{ id: task.threadId, title: "Fix login bug" }],
4852
};
4953

50-
const state = vi.hoisted(() => ({ connected: true, tasksLoaded: true, secondary: false }));
54+
const codex: ServerProvider = {
55+
instanceId: ProviderInstanceId.make("codex"),
56+
driver: ProviderDriverKind.make("codex"),
57+
enabled: true,
58+
installed: true,
59+
version: "1.0.0",
60+
status: "ready",
61+
auth: { status: "authenticated" },
62+
checkedAt: "2026-09-17T00:00:00.000Z",
63+
models: [
64+
{
65+
slug: "gpt-5.4",
66+
name: "GPT-5.4",
67+
isCustom: false,
68+
capabilities: createModelCapabilities({
69+
optionDescriptors: [
70+
{
71+
id: "reasoningEffort",
72+
label: "Reasoning",
73+
type: "select",
74+
role: "reasoning",
75+
options: [
76+
{ id: "low", label: "Low" },
77+
{ id: "medium", label: "Medium", isDefault: true },
78+
],
79+
},
80+
{
81+
id: "serviceTier",
82+
label: "Speed",
83+
type: "select",
84+
options: [
85+
{ id: "default", label: "Standard", isDefault: true },
86+
{ id: "priority", label: "Fast" },
87+
],
88+
},
89+
],
90+
}),
91+
},
92+
],
93+
slashCommands: [],
94+
skills: [],
95+
};
96+
const providersAtom = Atom.make<ReadonlyArray<ServerProvider>>([codex]);
97+
98+
const state = vi.hoisted(() => ({
99+
connected: true,
100+
tasksLoaded: true,
101+
secondary: false,
102+
taskOverride: null as ScheduledTask | null,
103+
upserts: [] as Array<ScheduledTaskUpsertInput>,
104+
}));
51105
const secondaryId = EnvironmentId.make("secondary");
52106
const permissions = new Map<string, Atom.Writable<boolean>>();
53107

54108
function setup() {
55109
state.connected = true;
56110
state.tasksLoaded = true;
57111
state.secondary = false;
112+
state.taskOverride = null;
113+
state.upserts = [];
58114
permissions.clear();
59115
permissions.set(environmentId, Atom.make(true));
60116
permissions.set(secondaryId, Atom.make(true));
@@ -108,9 +164,20 @@ vi.mock(import("../../state/server"), async (original) => {
108164
...actual.serverEnvironment.upsertScheduledTask,
109165
permissionAtom: (id: string | null) => permissions.get(id ?? "")!,
110166
},
167+
providersValueAtom: (() => providersAtom) as never,
111168
},
112169
};
113170
});
171+
vi.mock(import("~/state/session"), async (original) => ({
172+
...(await original()),
173+
readEnvironmentScope: () => true,
174+
}));
175+
vi.mock(import("../../state/use-atom-command"), () => ({
176+
useAtomCommand: (() => (request: { input?: ScheduledTaskUpsertInput }) => {
177+
if (request.input?.modelSelection) state.upserts.push(request.input);
178+
return Promise.resolve({ _tag: "Success", value: {} });
179+
}) as never,
180+
}));
114181
vi.mock(import("../../state/threads"), async (original) => {
115182
const actual = await original();
116183
return {
@@ -125,7 +192,7 @@ vi.mock(import("../../state/query"), async (original) => ({
125192
data:
126193
request === null || request === threadFamilyRead
127194
? request
128-
: { tasks: state.tasksLoaded ? [task] : [] },
195+
: { tasks: state.tasksLoaded ? [state.taskOverride ?? task] : [] },
129196
error: null,
130197
isPending: false,
131198
refresh: vi.fn(),
@@ -215,4 +282,44 @@ describe("ScheduledTasksSettings", () => {
215282
await expect.element(dialog.getByRole("heading", { name: "New task" })).toBeInTheDocument();
216283
await expect.element(name).toHaveValue("My draft");
217284
});
285+
286+
it("saves Fast and effort picked in the composer's picker to the task", async () => {
287+
setup();
288+
await using _screen = await render(<ScheduledTasksSettings taskId={task.id} />);
289+
const dialog = page.getByRole("dialog");
290+
await userEvent.click(dialog.getByRole("button", { name: /GPT-5\.4/ }));
291+
await userEvent.click(page.getByRole("radio", { name: "Low" }));
292+
await userEvent.click(page.getByRole("radio", { name: "Fast" }));
293+
await userEvent.keyboard("{Escape}");
294+
await userEvent.click(dialog.getByRole("button", { name: "Save task" }));
295+
296+
await vi.waitFor(() => expect(state.upserts).toHaveLength(1));
297+
expect(state.upserts[0]?.modelSelection).toEqual({
298+
instanceId: ProviderInstanceId.make("codex"),
299+
model: "gpt-5.4",
300+
options: [
301+
{ id: "reasoningEffort", value: "low" },
302+
{ id: "serviceTier", value: "priority" },
303+
],
304+
});
305+
});
306+
307+
it("reopens a task with its saved speed and effort", async () => {
308+
setup();
309+
state.taskOverride = {
310+
...task,
311+
modelSelection: {
312+
instanceId: ProviderInstanceId.make("codex"),
313+
model: "gpt-5.4",
314+
options: [
315+
{ id: "reasoningEffort", value: "low" },
316+
{ id: "serviceTier", value: "priority" },
317+
],
318+
},
319+
};
320+
await using _screen = await render(<ScheduledTasksSettings taskId={task.id} />);
321+
await userEvent.click(page.getByRole("dialog").getByRole("button", { name: /GPT-5\.4/ }));
322+
await expect.element(page.getByRole("radio", { name: "Fast" })).toBeChecked();
323+
await expect.element(page.getByRole("radio", { name: "Low" })).toBeChecked();
324+
});
218325
});

0 commit comments

Comments
 (0)