Skip to content

Commit e1c4114

Browse files
committed
test(contracts): cover every forward-compatible PR list field
Each list that now drops unknown members has a decode case, so one reverting to a strict array fails a test.
1 parent a1bb72e commit e1c4114

1 file changed

Lines changed: 33 additions & 0 deletions

File tree

‎packages/contracts/src/pullRequest.test.ts‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@ import {
88
PullRequestFilesViewedResult,
99
PullRequestListInput,
1010
PullRequestListResult,
11+
PullRequestProviderSummary,
1112
PullRequestReviewerRequestInput,
1213
PullRequestSetFilesViewedInput,
14+
PullRequestViewerPermissions,
1315
pullRequestHostOf,
1416
resolvePullRequestAuthorFilter,
1517
} from "./pullRequest.ts";
@@ -20,6 +22,8 @@ const decodeReviewerRequest = Schema.decodeUnknownSync(PullRequestReviewerReques
2022
const decodeAction = Schema.decodeUnknownSync(PullRequestActionInput);
2123
const decodeSetFilesViewed = Schema.decodeUnknownSync(PullRequestSetFilesViewedInput);
2224
const decodeFilesViewed = Schema.decodeUnknownSync(PullRequestFilesViewedResult);
25+
const decodeViewerPermissions = Schema.decodeUnknownSync(PullRequestViewerPermissions);
26+
const decodeProviderSummary = Schema.decodeUnknownSync(PullRequestProviderSummary);
2327

2428
const LIST_RESULT: PullRequestListResult = {
2529
viewers: { "github.com": "bilal", "gitlab.com": "bilal.hassan" },
@@ -279,12 +283,41 @@ describe("PullRequestCapabilities", () => {
279283
const decoded = decodeCapabilities({
280284
...base,
281285
actions: ["merge", "archive", "close"],
286+
mergeMethods: ["squash", "fast-forward"],
287+
updateMethods: ["rebase", "fast-forward"],
282288
review: { ...base.review, verdicts: ["approve", "block"] },
283289
});
284290

285291
expect(decoded.actions).toEqual(["merge", "close"]);
292+
expect(decoded.mergeMethods).toEqual(["squash"]);
293+
expect(decoded.updateMethods).toEqual(["rebase"]);
286294
expect(decoded.review.verdicts).toEqual(["approve"]);
287295
});
296+
297+
it("drops unknown values from viewer permissions and provider summaries", () => {
298+
const permissions = decodeViewerPermissions({
299+
actions: ["merge", "archive"],
300+
comment: true,
301+
resolve: true,
302+
verdicts: ["approve", "block"],
303+
requestReviewers: true,
304+
updateMethods: ["rebase", "fast-forward"],
305+
});
306+
expect(permissions.actions).toEqual(["merge"]);
307+
expect(permissions.verdicts).toEqual(["approve"]);
308+
expect(permissions.updateMethods).toEqual(["rebase"]);
309+
310+
const provider = decodeProviderSummary({
311+
host: "github.com",
312+
kind: "github",
313+
searchesOnHost: true,
314+
actions: ["merge", "archive"],
315+
projectCount: 1,
316+
configured: true,
317+
detail: null,
318+
});
319+
expect(provider.actions).toEqual(["merge"]);
320+
});
288321
});
289322

290323
describe("naming the reader as the author to narrow by", () => {

0 commit comments

Comments
 (0)