Skip to content

Commit e0d6aad

Browse files
feat(server): watched GitHub pull requests react when a check suite completes (#35709)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 82839de commit e0d6aad

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

‎packages/source-control-github/src/server/gitHubPullRequestEvents.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ it.effect("follows a pull request across a refused app token, reconnects, and re
120120
"com.github.pull_request.head.changed.v1",
121121
"com.github.pull_request.state.changed.v1",
122122
"com.github.pull_request.merge_conflict.v1",
123+
"com.github.pull_request.check_suite.status.changed.v1",
123124
],
124125
});
125126
assert.deepEqual(deletes, ["event-subscriptions/1", "event-subscriptions/2"]);

‎packages/source-control-github/src/server/gitHubPullRequestEvents.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,13 @@ import { HttpClient, HttpClientRequest } from "effect/http";
1212

1313
import * as GitHubRest from "./GitHubRest.ts";
1414

15-
/** Events only say that something changed; readers fetch the pull request for what. */
15+
/** Readers fetch the pull request on every event, so check suites' conclusions go unused. */
1616
const EVENT_TYPES = [
1717
"com.github.pull_request.review.submitted.v1",
1818
"com.github.pull_request.head.changed.v1",
1919
"com.github.pull_request.state.changed.v1",
2020
"com.github.pull_request.merge_conflict.v1",
21+
"com.github.pull_request.check_suite.status.changed.v1",
2122
];
2223
const API_ORIGIN = "https://api.github.com";
2324
/** GitHub sends a keep-alive at least every 15 seconds while a stream is idle. */

0 commit comments

Comments
 (0)