Skip to content

Commit df3bae3

Browse files
docs(mobile): scope the rpc defect classifier comment to the request path
Effect's RpcClientDefect tag is also reused by the shared config-subscription stream to re-wrap transport causes. On the queued-request path that drives this logger, the RPC client reports ordinary drops as raw socket/worker reason tags and reserves the defect tag for protocol/decode failures, so the tag check is right here and only the comment was overstated. Co-authored-by: Apex by Callstack <[email protected]>
1 parent 34b6394 commit df3bae3

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

‎apps/mobile/src/state/use-thread-outbox-drain.ts‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,13 @@ import {
9191
const threadOutboxDebug = createDebugLogger("thread-outbox");
9292

9393
/**
94-
* The RPC transport tags also cover client-side response-decoding defects —
95-
* abnormal server responses, not offline behavior. Those still retry, but
96-
* they must not hide behind the ordinary-offline debug log.
94+
* On the queued-request path (settings sync, startTurn) the RPC client
95+
* reports ordinary transport drops as the raw socket/worker reason tags, and
96+
* reserves `RpcClientDefect` for client-side protocol violations and decoding
97+
* failures — unlike the shared config-subscription stream, which
98+
* deliberately re-wraps transport causes under that tag. Defects still retry,
99+
* but they are not ordinary offline behavior and must not hide behind the
100+
* offline debug log.
97101
*/
98102
function isRpcClientDecodeDefect(error: unknown): boolean {
99103
if (

0 commit comments

Comments
 (0)