Repository navigation
Commit df08561
committed
fix(pr): count cancelled runs as failing in the list rollup
The list rollup ignored cancelled runs while the client's detail rollup read them as failing, so a head with one cancelled run flapped between failing and a stale-checks banner once the two were compared. Both now agree, matching how GitHub's own rollup reads it. Also memoize the linked-thread reference so sidebar rows stop touching the shared summary cache every render.1 parent 122e012 commit df08561
3 files changed
Lines changed: 19 additions & 6 deletions
File tree
- apps
- server/src/pullRequest
- web/src/components
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
124 | 131 | | |
125 | 132 | | |
126 | 133 | | |
| |||
132 | 139 | | |
133 | 140 | | |
134 | 141 | | |
| 142 | + | |
135 | 143 | | |
136 | 144 | | |
137 | 145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1447 | 1447 | | |
1448 | 1448 | | |
1449 | 1449 | | |
1450 | | - | |
1451 | | - | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
1452 | 1453 | | |
1453 | 1454 | | |
1454 | 1455 | | |
| |||
1463 | 1464 | | |
1464 | 1465 | | |
1465 | 1466 | | |
1466 | | - | |
| 1467 | + | |
1467 | 1468 | | |
1468 | 1469 | | |
1469 | 1470 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | | - | |
81 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
82 | 86 | | |
83 | 87 | | |
84 | 88 | | |
| |||
0 commit comments