Skip to content

Commit dddb610

Browse files
committed
fix(server): skip current only after a live version probe
refreshInstance can return the cached row on unknown ids or probe failure. Skip now requires checkedAt to change, so a cached current advisory cannot hide an unverified binary.
1 parent 746c80f commit dddb610

2 files changed

Lines changed: 54 additions & 3 deletions

File tree

‎apps/server/src/provider/providerMaintenanceRunner.test.ts‎

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,13 @@ describe("providerMaintenanceRunner", () => {
317317
refreshedInstanceIds.push(instanceId);
318318
return Ref.updateAndGet(providersRef, (providers) =>
319319
providers.map((provider) =>
320-
provider.instanceId === instanceId ? { ...provider, version: "2.1.310" } : provider,
320+
provider.instanceId === instanceId
321+
? {
322+
...provider,
323+
version: "2.1.310",
324+
checkedAt: "2026-04-10T00:00:01.000Z",
325+
}
326+
: provider,
321327
),
322328
);
323329
},
@@ -360,6 +366,44 @@ describe("providerMaintenanceRunner", () => {
360366
);
361367
});
362368

369+
it.effect("still runs the installer when refreshInstance returns the cached snapshot", () => {
370+
const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
371+
return Effect.gen(function* () {
372+
const { registry } = yield* makeRegistry({
373+
...baseProvider,
374+
version: "2.1.310",
375+
});
376+
const updater = yield* makeTestRunner({
377+
...registry,
378+
getProviderMaintenanceCapabilitiesForInstance: () =>
379+
Effect.succeed(
380+
makeProviderMaintenanceCapabilities({
381+
provider: CODEX_DRIVER,
382+
packageName: "@anthropic-ai/claude-code",
383+
updateExecutable: "claude",
384+
updateArgs: ["update"],
385+
updateLockKey: "claudeAgent-native",
386+
}),
387+
),
388+
});
389+
390+
const result = yield* updater.updateProvider(CODEX_DRIVER);
391+
assert.deepStrictEqual(calls, [{ command: "claude", args: ["update"] }]);
392+
assert.strictEqual(result.providers[0]?.updateState?.status, "succeeded");
393+
}).pipe(
394+
Effect.provide(
395+
Layer.mergeAll(
396+
layerNonWindowsPlatform,
397+
layerLatestVersionHttpClient("2.1.310"),
398+
layerMockSpawner((command, args) => {
399+
calls.push({ command, args });
400+
return { stdout: "updated" };
401+
}),
402+
),
403+
),
404+
);
405+
});
406+
363407
it.effect("still runs the installer when the installed version is unknown", () => {
364408
const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
365409
return Effect.gen(function* () {

‎apps/server/src/provider/providerMaintenanceRunner.ts‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -514,17 +514,24 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
514514
// not run the installer when the binary is already current.
515515
// Unknown version stays on the installer path.
516516
if (targetVersion === undefined) {
517+
const providersBeforeProbe = yield* providerRegistry.getProviders;
517518
const precheck = yield* verifyFromRefresh(
518519
providerRegistry.refreshInstance(instanceId),
519520
provider,
520521
fresh,
521522
instanceId,
522523
"pre-update",
523524
);
525+
const liveProbedProviders = precheck.verifiedProviders.filter((verified) => {
526+
const prior = providersBeforeProbe.find(
527+
(candidate) => candidate.instanceId === verified.instanceId,
528+
);
529+
return prior !== undefined && prior.checkedAt !== verified.checkedAt;
530+
});
524531
const alreadyCurrent =
525532
precheck.advisoryEnriched &&
526-
precheck.verifiedProviders.length > 0 &&
527-
precheck.verifiedProviders.every(isAlreadyOnLatest);
533+
liveProbedProviders.length > 0 &&
534+
liveProbedProviders.every(isAlreadyOnLatest);
528535
if (alreadyCurrent) {
529536
return yield* finish(
530537
makeUpdateState({

0 commit comments

Comments
 (0)