Skip to content

Commit dcce6cf

Browse files
committed
fix: apply CodeRabbit auto-fixes
1 parent 2677dda commit dcce6cf

7 files changed

Lines changed: 92 additions & 12 deletions

File tree

‎apps/web/src/components/DiffPanel.tsx‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1152,15 +1152,20 @@ export default function DiffPanel({
11521152
</div>
11531153
{fileTreeOpen ? (
11541154
<aside
1155-
className="relative flex shrink-0 border-l border-border/60"
1155+
className="relative flex w-(--resizable-width) shrink-0 border-l border-border/60"
11561156
style={
11571157
{
11581158
[RESIZABLE_WIDTH_PROPERTY]: `${filesPanel.width}px`,
1159-
width: `var(${RESIZABLE_WIDTH_PROPERTY})`,
11601159
} as CSSProperties
11611160
}
11621161
>
1163-
<RightPanelResizeHandle handlers={filesPanel.handlers} />
1162+
<RightPanelResizeHandle
1163+
ariaLabel="Resize Files panel"
1164+
handlers={filesPanel.handlers}
1165+
width={filesPanel.width}
1166+
minWidth={filesPanel.minWidth}
1167+
maxWidth={filesPanel.maxWidth}
1168+
/>
11641169
<DiffFileTree
11651170
ariaLabel={`${reviewSectionTitle} files`}
11661171
entries={fileTreeEntries}

‎apps/web/src/components/preview/PreviewPanelShell.tsx‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ function PreviewPanelShellFrame(
6666
const localHostRef = useRef<HTMLDivElement | null>(null);
6767
const hostRef = props.hostRef ?? localHostRef;
6868
const returnedFocus = useRef(false);
69-
const { width, handlers } = props.inlineSize;
69+
const { width, minWidth, maxWidth, handlers } = props.inlineSize;
7070
// Derive suppression before the layout commits so the browser never creates
7171
// a width transition for resize or maximize changes.
7272
const [layoutTransition, setLayoutTransition] = useState(() => ({
@@ -166,7 +166,15 @@ function PreviewPanelShellFrame(
166166
data-preview-panel-mode={props.mode}
167167
data-preview-panel-maximized={maximized ? "true" : "false"}
168168
>
169-
{isInline && !maximized ? <RightPanelResizeHandle handlers={handlers} /> : null}
169+
{isInline && !maximized ? (
170+
<RightPanelResizeHandle
171+
ariaLabel="Resize preview panel"
172+
handlers={handlers}
173+
width={width}
174+
minWidth={minWidth}
175+
maxWidth={maxWidth}
176+
/>
177+
) : null}
170178
<div className={cn("h-full min-h-0 w-full", collapsible && "overflow-clip")}>
171179
<div
172180
className="flex h-full min-h-0 min-w-0 flex-col"

‎apps/web/src/components/preview/RightPanelResizeHandle.tsx‎

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,32 @@ import { cn } from "~/lib/utils";
33

44
interface Props {
55
handlers: ResizableWidthHandlers;
6+
width: number;
7+
minWidth: number;
8+
maxWidth: number;
9+
ariaLabel: string;
610
className?: string;
711
}
812

9-
export function RightPanelResizeHandle({ handlers, className }: Props) {
13+
export function RightPanelResizeHandle({
14+
handlers,
15+
width,
16+
minWidth,
17+
maxWidth,
18+
ariaLabel,
19+
className,
20+
}: Props) {
1021
return (
1122
<div
1223
role="separator"
1324
aria-orientation="vertical"
25+
aria-label={ariaLabel}
26+
aria-valuenow={width}
27+
aria-valuemin={minWidth}
28+
aria-valuemax={Number.isFinite(maxWidth) ? maxWidth : undefined}
29+
tabIndex={0}
1430
className={cn(
15-
"group absolute inset-y-0 -left-1 z-20 w-2 cursor-col-resize select-none",
31+
"group absolute inset-y-0 -left-1 z-20 w-2 cursor-col-resize select-none outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-ring focus-visible:ring-offset-1 focus-visible:ring-offset-background",
1632
className,
1733
)}
1834
{...handlers}

‎apps/web/src/components/pullRequest/PullRequestCodeTab.tsx‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1485,15 +1485,20 @@ function PullRequestCodeTab({
14851485
</div>
14861486
{fileTreeOpen ? (
14871487
<aside
1488-
className="relative flex shrink-0 border-l border-border/60"
1488+
className="relative flex w-(--resizable-width) shrink-0 border-l border-border/60"
14891489
style={
14901490
{
14911491
[RESIZABLE_WIDTH_PROPERTY]: `${filesPanel.width}px`,
1492-
width: `var(${RESIZABLE_WIDTH_PROPERTY})`,
14931492
} as CSSProperties
14941493
}
14951494
>
1496-
<RightPanelResizeHandle handlers={filesPanel.handlers} />
1495+
<RightPanelResizeHandle
1496+
ariaLabel="Resize Files panel"
1497+
handlers={filesPanel.handlers}
1498+
width={filesPanel.width}
1499+
minWidth={filesPanel.minWidth}
1500+
maxWidth={filesPanel.maxWidth}
1501+
/>
14971502
<DiffFileTree
14981503
ariaLabel={`${capitalizeTerm(term)} #${detail.number} files`}
14991504
entries={fileTreeEntries}

‎apps/web/src/hooks/useDiffFileTreePanelSize.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ const CODE_VIEW_MIN_WIDTH = 360;
1515

1616
export interface DiffFileTreePanelSize {
1717
readonly width: number;
18+
readonly minWidth: number;
19+
readonly maxWidth: number;
1820
readonly handlers: ResizableWidthHandlers;
1921
}
2022

‎apps/web/src/hooks/usePreviewPanelInlineSize.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import { observeResize } from "../lib/observeResize";
55

66
export interface PreviewPanelInlineSize {
77
readonly width: number;
8+
readonly minWidth: number;
9+
readonly maxWidth: number;
810
readonly handlers: ResizableWidthHandlers;
911
}
1012

‎apps/web/src/hooks/useResizableWidth.ts‎

Lines changed: 44 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
import * as Schema from "effect/Schema";
2-
import { type PointerEvent as ReactPointerEvent, useLayoutEffect, useRef, useState } from "react";
2+
import {
3+
type KeyboardEvent as ReactKeyboardEvent,
4+
type PointerEvent as ReactPointerEvent,
5+
useLayoutEffect,
6+
useRef,
7+
useState,
8+
} from "react";
39

410
import { getLocalStorageItem, setLocalStorageItem } from "./useLocalStorage";
511
import { useResizeDrag } from "./useResizeDrag";
@@ -20,19 +26,25 @@ export interface UseResizableWidthOptions {
2026
}
2127

2228
export interface ResizableWidthHandlers {
29+
readonly onKeyDown: (event: ReactKeyboardEvent<HTMLElement>) => void;
2330
readonly onPointerDown: (event: ReactPointerEvent<HTMLElement>) => void;
2431
readonly onPointerMove: (event: ReactPointerEvent<HTMLElement>) => void;
2532
readonly onPointerUp: (event: ReactPointerEvent<HTMLElement>) => void;
2633
readonly onPointerCancel: (event: ReactPointerEvent<HTMLElement>) => void;
2734
readonly onLostPointerCapture: (event: ReactPointerEvent<HTMLElement>) => void;
2835
}
2936

37+
const KEYBOARD_RESIZE_STEP = 16;
38+
const KEYBOARD_RESIZE_LARGE_STEP = 64;
39+
3040
/**
3141
* Width is read on mount or storage-key changes and persisted on drag-end (not on every rAF tick
3242
* — would otherwise be ~60 writes/sec).
3343
*/
3444
export function useResizableWidth(options: UseResizableWidthOptions): {
3545
readonly width: number;
46+
readonly minWidth: number;
47+
readonly maxWidth: number;
3648
readonly handlers: ResizableWidthHandlers;
3749
} {
3850
const { storageKey, defaultWidth, minWidth, maxWidth, edge } = options;
@@ -98,5 +110,35 @@ export function useResizableWidth(options: UseResizableWidthOptions): {
98110
// rewrites the committed width, so re-apply the live pointer position.
99111
useLayoutEffect(refresh, [clamp, clampedWidth, refresh]);
100112

101-
return { width: clampedWidth, handlers };
113+
const onKeyDown = (event: ReactKeyboardEvent<HTMLElement>) => {
114+
if (event.nativeEvent.isComposing || event.ctrlKey || event.altKey || event.metaKey) return;
115+
116+
let nextWidth: number | undefined;
117+
if (event.key === "Home") {
118+
nextWidth = minWidth;
119+
} else if (event.key === "End" && Number.isFinite(maxWidth)) {
120+
nextWidth = maxWidth;
121+
} else if (event.key === "ArrowLeft" || event.key === "ArrowRight") {
122+
const step = event.shiftKey ? KEYBOARD_RESIZE_LARGE_STEP : KEYBOARD_RESIZE_STEP;
123+
const direction =
124+
event.key === "ArrowLeft" ? (edge === "left" ? 1 : -1) : edge === "left" ? -1 : 1;
125+
nextWidth = clamp(clampedWidth + direction * step);
126+
}
127+
if (nextWidth === undefined) return;
128+
129+
event.preventDefault();
130+
if (nextWidth === clampedWidth) return;
131+
event.currentTarget.parentElement?.style.setProperty(
132+
RESIZABLE_WIDTH_PROPERTY,
133+
`${nextWidth}px`,
134+
);
135+
setWidthState({ storageKey, width: nextWidth });
136+
try {
137+
setLocalStorageItem(storageKey, nextWidth, WidthSchema);
138+
} catch (error) {
139+
console.error("Could not persist panel width.", error);
140+
}
141+
};
142+
143+
return { width: clampedWidth, minWidth, maxWidth, handlers: { ...handlers, onKeyDown } };
102144
}

0 commit comments

Comments
 (0)