Skip to content

Commit db57218

Browse files
chore(server): clarify lifetime pipe verification comments
1 parent 9943cf3 commit db57218

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎apps/server/src/desktopLifetime.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ describe.skipIf(HostProcess.Platform.defaultValue() === "win32")("DesktopLifetim
107107
lifetimePipe.destroy();
108108
yield* takeLine(desktop.lines, "ready");
109109

110-
// Telemetry and browser IPC can close independently of desktop lifetime.
110+
// Close unused pipe endpoints; FD 8 remains owned by the desktop fixture.
111111
for (const fd of [4, 5, 6, 7]) backend.child.stdio[fd]?.destroy();
112112
yield* takeLine(backend.lines, "ready");
113113
backend.child.stdin?.write("ping");

‎apps/server/src/desktopLifetime.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// @effect-diagnostics nodeBuiltinImport:off -- net.Socket watches the inherited pipe without occupying a threadpool thread.
1+
// @effect-diagnostics nodeBuiltinImport:off -- net.Socket reads the inherited pipe asynchronously.
22
import * as NodeNet from "node:net";
33

44
import * as Effect from "effect/Effect";

0 commit comments

Comments
 (0)