Skip to content

Commit db0f475

Browse files
committed
fix(web): show approved reviews with a human check icon
1 parent e239cb4 commit db0f475

1 file changed

Lines changed: 15 additions & 11 deletions

File tree

‎apps/web/src/components/pullRequest/PullRequestRow.tsx‎

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { SearchIcon } from "lucide-react";
1+
import { SearchIcon, UserCheckIcon } from "lucide-react";
22
import { PullRequestStackPopover } from "./PullRequestStackPopover";
33
import { memo, type RefCallback } from "react";
44

@@ -197,16 +197,20 @@ function PullRequestRowImpl({
197197
{entry.labels.length > 0 ? <PullRequestRowLabels labels={entry.labels} /> : null}
198198
{/* Only a verdict somebody has actually given: "review required" is the absence of
199199
one, and saying so on every unreviewed row would say nothing. */}
200-
{entry.reviewDecision === "approved" || entry.reviewDecision === "changes-requested" ? (
201-
<span
202-
className={cn(
203-
"min-w-0 truncate",
204-
entry.reviewDecision === "approved"
205-
? "text-emerald-600/90 dark:text-emerald-400/80"
206-
: "text-amber-600/90 dark:text-amber-400/80",
207-
)}
208-
>
209-
{entry.reviewDecision === "approved" ? "Approved" : "Changes requested"}
200+
{entry.reviewDecision === "approved" ? (
201+
<Tooltip>
202+
<TooltipTrigger render={<span className="inline-flex shrink-0" />}>
203+
<UserCheckIcon
204+
aria-hidden
205+
className="size-3.5 text-emerald-600/90 dark:text-emerald-400/80"
206+
/>
207+
<span className="sr-only">Approved</span>
208+
</TooltipTrigger>
209+
<TooltipPopup>Approved</TooltipPopup>
210+
</Tooltip>
211+
) : entry.reviewDecision === "changes-requested" ? (
212+
<span className="min-w-0 truncate text-amber-600/90 dark:text-amber-400/80">
213+
Changes requested
210214
</span>
211215
) : null}
212216
{entry.checksState === undefined ? null : (

0 commit comments

Comments
 (0)