Skip to content

Commit d866815

Browse files
fix(server): align pinned input ordering
1 parent ffd0a41 commit d866815

2 files changed

Lines changed: 7 additions & 10 deletions

File tree

‎apps/server/src/orchestration/Layers/ProjectionSnapshotQuery.test.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2355,12 +2355,12 @@ projectionSnapshotLayer("ProjectionSnapshotQuery windowed thread detail", (it) =
23552355
),
23562356
(
23572357
'user-input-tied-z-request', 'thread-w', NULL, 'approval', 'user-input.requested',
2358-
'Tied closed question', '{"requestId":"input-tied-closed"}', NULL,
2358+
'Tied open question', '{"requestId":"input-tied-open"}', NULL,
23592359
'2026-03-01T00:00:05.000Z'
23602360
),
23612361
(
23622362
'user-input-tied-a-resolution', 'thread-w', NULL, 'info', 'user-input.resolved',
2363-
'Tied closed question', '{"requestId":"input-tied-closed"}', NULL,
2363+
'Tied open question', '{"requestId":"input-tied-open"}', NULL,
23642364
'2026-03-01T00:00:05.000Z'
23652365
)
23662366
`;
@@ -2383,11 +2383,11 @@ projectionSnapshotLayer("ProjectionSnapshotQuery windowed thread detail", (it) =
23832383
assert.equal(detailWithPinnedRequests._tag, "Some");
23842384
if (detailWithPinnedRequests._tag === "Some") {
23852385
const ids = detailWithPinnedRequests.value.activities.map((activity) => activity.id);
2386-
assert.equal(detailWithPinnedRequests.value.activities.length, 502);
2386+
assert.equal(detailWithPinnedRequests.value.activities.length, 503);
23872387
assert.equal(ids.includes(asEventId("approval-old")), true);
23882388
assert.equal(ids.includes(asEventId("user-input-old")), true);
23892389
assert.equal(ids.includes(asEventId("user-input-closed")), false);
2390-
assert.equal(ids.includes(asEventId("user-input-tied-z-request")), false);
2390+
assert.equal(ids.includes(asEventId("user-input-tied-z-request")), true);
23912391
}
23922392

23932393
const windowWithPinnedRequests = yield* snapshotQuery.getThreadDetailSnapshot(threadW, {
@@ -2396,11 +2396,11 @@ projectionSnapshotLayer("ProjectionSnapshotQuery windowed thread detail", (it) =
23962396
assert.equal(windowWithPinnedRequests._tag, "Some");
23972397
if (windowWithPinnedRequests._tag === "Some") {
23982398
const ids = windowWithPinnedRequests.value.thread.activities.map((activity) => activity.id);
2399-
assert.equal(windowWithPinnedRequests.value.thread.activities.length, 502);
2399+
assert.equal(windowWithPinnedRequests.value.thread.activities.length, 503);
24002400
assert.equal(ids.includes(asEventId("approval-old")), true);
24012401
assert.equal(ids.includes(asEventId("user-input-old")), true);
24022402
assert.equal(ids.includes(asEventId("user-input-closed")), false);
2403-
assert.equal(ids.includes(asEventId("user-input-tied-z-request")), false);
2403+
assert.equal(ids.includes(asEventId("user-input-tied-z-request")), true);
24042404
}
24052405
}),
24062406
);

‎apps/server/src/orchestration/Layers/ProjectionSnapshotQuery.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,10 +1292,7 @@ const makeProjectionSnapshotQuery = Effect.gen(function* () {
12921292
activity.kind,
12931293
ROW_NUMBER() OVER (
12941294
PARTITION BY json_extract(activity.payload_json, '$.requestId')
1295-
ORDER BY
1296-
activity.created_at DESC,
1297-
CASE WHEN activity.kind = 'user-input.requested' THEN 0 ELSE 1 END DESC,
1298-
activity.activity_id DESC
1295+
ORDER BY activity.created_at DESC, activity.activity_id DESC
12991296
) AS request_order
13001297
FROM pending_user_input_thread AS pending
13011298
CROSS JOIN projection_thread_activities AS activity

0 commit comments

Comments
 (0)