Skip to content

Commit d5079a9

Browse files
fix(mobile): stop refreshing Git status on streamed thread updates
1 parent 17d4c28 commit d5079a9

1 file changed

Lines changed: 18 additions & 4 deletions

File tree

‎apps/mobile/src/state/use-selected-thread-git-actions.ts‎

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useCallback, useEffect, useMemo } from "react";
1+
import { useCallback, useEffect, useEffectEvent, useMemo } from "react";
22

33
import { EnvironmentProject, EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
44
import type { AtomCommandResult } from "@t3tools/client-runtime/state/runtime";
@@ -140,12 +140,26 @@ export function useSelectedThreadGitActions() {
140140
[refreshStatus, selectedThread, selectedThreadCwd, selectedThreadProject],
141141
);
142142

143+
// Shell updates replace the selected thread object many times per second while a
144+
// turn streams, so key the refresh on primitives. The server publishes status after
145+
// each turn finishes; this only seeds status when the selection or cwd changes.
146+
const selectedEnvironmentId = selectedThread?.environmentId ?? null;
147+
const selectedThreadId = selectedThread?.id ?? null;
148+
const hasSelectedThreadProject = selectedThreadProject !== null;
149+
const refreshOnSelection = useEffectEvent(() => {
150+
void refreshSelectedThreadGitStatus({ quiet: true });
151+
});
143152
useEffect(() => {
144-
if (!selectedThread || !selectedThreadProject) {
153+
if (
154+
selectedEnvironmentId === null ||
155+
selectedThreadId === null ||
156+
!hasSelectedThreadProject ||
157+
selectedThreadCwd === null
158+
) {
145159
return;
146160
}
147-
void refreshSelectedThreadGitStatus({ quiet: true });
148-
}, [refreshSelectedThreadGitStatus, selectedThread, selectedThreadProject]);
161+
refreshOnSelection();
162+
}, [selectedEnvironmentId, selectedThreadId, hasSelectedThreadProject, selectedThreadCwd]);
149163

150164
const runSelectedThreadGitMutation = useCallback(
151165
async <T, E>(

0 commit comments

Comments
 (0)