@@ -432,35 +432,41 @@ export function applyServerSettingsPatch(
432432 const initialFavorites =
433433 patch . favorites ?? current . favorites ?? migrateModelPreferences ?. favorites ?? null ;
434434 const favorites =
435- setModelFavorites ?. reduce ( ( current , change ) => {
436- const exists = current . some (
437- ( favorite ) => favorite . provider === change . provider && favorite . model === change . model ,
438- ) ;
439- return change . favorite
440- ? exists
441- ? current
442- : [ ...current , { provider : change . provider , model : change . model } ]
443- : current . filter (
444- ( favorite ) => favorite . provider !== change . provider || favorite . model !== change . model ,
445- ) ;
446- } , initialFavorites ?? [ ] ) ?? initialFavorites ;
435+ setModelFavorites ?. reduce (
436+ ( current , change ) => {
437+ const exists = current . some (
438+ ( favorite ) => favorite . provider === change . provider && favorite . model === change . model ,
439+ ) ;
440+ if ( change . favorite ) {
441+ if ( ! exists ) current . push ( { provider : change . provider , model : change . model } ) ;
442+ return current ;
443+ }
444+ return current . filter (
445+ ( favorite ) => favorite . provider !== change . provider || favorite . model !== change . model ,
446+ ) ;
447+ } ,
448+ [ ...( initialFavorites ?? [ ] ) ] ,
449+ ) ?? initialFavorites ;
447450 const initialModelPreferences =
448451 providerModelPreferences ??
449452 current . providerModelPreferences ??
450453 migrateModelPreferences ?. providerModelPreferences ??
451454 null ;
452455 let nextModelPreferences = initialModelPreferences ;
453- for ( const change of setModelsHidden ?? [ ] ) {
454- const preferences = nextModelPreferences ?. [ change . provider ] ?? {
455- hiddenModels : [ ] ,
456- modelOrder : [ ] ,
457- } ;
458- const hiddenModels = preferences . hiddenModels . filter ( ( model ) => model !== change . model ) ;
459- if ( change . hidden ) hiddenModels . push ( change . model ) ;
460- nextModelPreferences = {
461- ...nextModelPreferences ,
462- [ change . provider ] : { ...preferences , hiddenModels } ,
463- } ;
456+ if ( setModelsHidden ?. length ) {
457+ const updated = { ...initialModelPreferences } ;
458+ for ( const change of setModelsHidden ) {
459+ const preferences = ( Object . hasOwn ( updated , change . provider )
460+ ? updated [ change . provider ]
461+ : undefined ) ?? {
462+ hiddenModels : [ ] ,
463+ modelOrder : [ ] ,
464+ } ;
465+ const hiddenModels = preferences . hiddenModels . filter ( ( model ) => model !== change . model ) ;
466+ if ( change . hidden ) hiddenModels . push ( change . model ) ;
467+ updated [ change . provider ] = { ...preferences , hiddenModels } ;
468+ }
469+ nextModelPreferences = updated ;
464470 }
465471 if ( setProviderModelOrder ) {
466472 const preferences = nextModelPreferences ?. [ setProviderModelOrder . provider ] ?? {
0 commit comments