77 type DesktopUpdateCheckResult ,
88 type DesktopUpdateState ,
99} from "@t3tools/contracts" ;
10+ import { errorTag } from "@t3tools/shared/observability" ;
1011import * as Cause from "effect/Cause" ;
1112import * as Context from "effect/Context" ;
1213import * as DateTime from "effect/DateTime" ;
@@ -196,6 +197,63 @@ const {
196197 logError : logUpdaterError ,
197198} = DesktopObservability . makeComponentLogger ( "desktop-updater" ) ;
198199
200+ function redactMessage ( message : string ) : string {
201+ // Updater HTTP errors append response bodies and headers after the first line.
202+ return ( message . split ( / [ \r \n ] / , 1 ) [ 0 ] ?? "" )
203+ . replace ( / \b (?: h t t p s ? | f i l e ) : \/ \/ [ ^ \s " ' < > ] + / gi, "[redacted URL]" )
204+ . replace ( / \b (?: B e a r e r | B a s i c ) \s + [ ^ \s , ; ] + / gi, "[redacted credential]" )
205+ . replace (
206+ / \b (?: a u t h o r i z a t i o n | p r o x y - a u t h o r i z a t i o n | c o o k i e | s e t - c o o k i e ) \s * [: = ] .* $ / gi,
207+ "[redacted header]" ,
208+ )
209+ . replace (
210+ / \b [ \w - ] * (?: t o k e n | p a s s w o r d | s e c r e t | c r e d e n t i a l | a p i [ _ - ] ? k e y ) [ \w - ] * \s * [: = ] \s * (?: " [ ^ " ] * " | ' [ ^ ' ] * ' | [ ^ \s , ; ] + ) / gi,
211+ "[redacted credential]" ,
212+ )
213+ . slice ( 0 , 512 ) ;
214+ }
215+
216+ function summarizeCause ( cause : unknown , depth : number ) : string {
217+ if ( depth >= 3 ) return "[truncated cause]" ;
218+ if ( Cause . isCause ( cause ) ) {
219+ return cause . reasons
220+ . slice ( 0 , 3 )
221+ . map ( ( reason ) =>
222+ reason . _tag === "Fail"
223+ ? summarizeCause ( reason . error , depth + 1 )
224+ : reason . _tag === "Die"
225+ ? summarizeCause ( reason . defect , depth + 1 )
226+ : "Interrupted" ,
227+ )
228+ . join ( "; " ) ;
229+ }
230+ if ( typeof cause === "string" ) return redactMessage ( cause ) ;
231+ if ( typeof cause !== "object" || cause === null ) return errorTag ( cause ) ;
232+
233+ const error = cause as {
234+ readonly message ?: unknown ;
235+ readonly code ?: unknown ;
236+ readonly cause ?: unknown ;
237+ } ;
238+ const code =
239+ typeof error . code === "string" && / ^ [ A - Z ] [ A - Z 0 - 9 _ ] { 0 , 127 } $ / . test ( error . code )
240+ ? ` [${ error . code } ]`
241+ : "" ;
242+ const message = typeof error . message === "string" ? `: ${ redactMessage ( error . message ) } ` : "" ;
243+ const nested =
244+ error . cause === undefined ? "" : `; caused by ${ summarizeCause ( error . cause , depth + 1 ) } ` ;
245+ return `${ errorTag ( cause ) } ${ code } ${ message } ${ nested } ` ;
246+ }
247+
248+ /** Log a bounded cause summary without stacks, response payloads, or request credentials. */
249+ export function describeUpdateErrorCause ( cause : unknown ) : string {
250+ try {
251+ return summarizeCause ( cause , 0 ) . slice ( 0 , 1024 ) ;
252+ } catch {
253+ return "UnknownError" ;
254+ }
255+ }
256+
199257function parseAppUpdateYml ( raw : string ) : Effect . Effect < Option . Option < AppUpdateYmlConfig > > {
200258 const entries : Record < string , string > = { } ;
201259 for ( const line of raw . split ( "\n" ) ) {
@@ -442,6 +500,7 @@ export const make = Effect.gen(function* () {
442500 ) ;
443501 yield * logUpdaterError ( error . message , {
444502 errorTag : error . _tag ,
503+ cause : describeUpdateErrorCause ( error . cause ) ,
445504 channel : error . channel ,
446505 } ) ;
447506 return true ;
@@ -485,6 +544,7 @@ export const make = Effect.gen(function* () {
485544 ) ;
486545 yield * logUpdaterError ( error . message , {
487546 errorTag : error . _tag ,
547+ cause : describeUpdateErrorCause ( error . cause ) ,
488548 channel : error . channel ,
489549 } ) ;
490550 return { accepted : true , completed : false } ;
@@ -507,6 +567,7 @@ export const make = Effect.gen(function* () {
507567 ) ;
508568 yield * logUpdaterError ( error . message , {
509569 errorTag : error . _tag ,
570+ cause : describeUpdateErrorCause ( error . cause ) ,
510571 action : error . action ,
511572 } ) ;
512573 return { accepted : true , completed : false } ;
@@ -655,6 +716,7 @@ export const make = Effect.gen(function* () {
655716 yield * recoverFailedInstall ( error . message ) ;
656717 yield * logUpdaterError ( error . message , {
657718 errorTag : error . _tag ,
719+ cause : describeUpdateErrorCause ( error . cause ) ,
658720 channel : error . channel ,
659721 isSilent : error . isSilent ,
660722 isForceRunAfter : error . isForceRunAfter ,
@@ -673,6 +735,7 @@ export const make = Effect.gen(function* () {
673735 yield * recoverFailedInstall ( error . message ) ;
674736 yield * logUpdaterError ( error . message , {
675737 errorTag : error . _tag ,
738+ cause : describeUpdateErrorCause ( error . cause ) ,
676739 action : error . action ,
677740 } ) ;
678741 return { accepted : true , completed : false , failed : true } ;
@@ -712,6 +775,7 @@ export const make = Effect.gen(function* () {
712775 const error = new DesktopUpdatePollerError ( { poller : "startup" , cause } ) ;
713776 return logUpdaterError ( error . message , {
714777 errorTag : error . _tag ,
778+ cause : describeUpdateErrorCause ( error . cause ) ,
715779 poller : error . poller ,
716780 } ) ;
717781 } ) ,
@@ -727,6 +791,7 @@ export const make = Effect.gen(function* () {
727791 const error = new DesktopUpdatePollerError ( { poller : "poll" , cause } ) ;
728792 return logUpdaterError ( error . message , {
729793 errorTag : error . _tag ,
794+ cause : describeUpdateErrorCause ( error . cause ) ,
730795 poller : error . poller ,
731796 } ) ;
732797 } ) ,
@@ -782,6 +847,7 @@ export const make = Effect.gen(function* () {
782847 const error = new DesktopUpdateEventHandlingError ( { event : "update-available" , cause } ) ;
783848 return logUpdaterWarning ( error . message , {
784849 errorTag : error . _tag ,
850+ cause : describeUpdateErrorCause ( error . cause ) ,
785851 event : error . event ,
786852 } ) ;
787853 } ) ,
@@ -811,6 +877,7 @@ export const make = Effect.gen(function* () {
811877 yield * recoverFailedInstall ( error . message ) ;
812878 yield * logUpdaterError ( error . message , {
813879 errorTag : error . _tag ,
880+ cause : describeUpdateErrorCause ( error . cause ) ,
814881 operation : error . operation ,
815882 } ) ;
816883 return ;
@@ -831,6 +898,7 @@ export const make = Effect.gen(function* () {
831898
832899 yield * logUpdaterError ( error . message , {
833900 errorTag : error . _tag ,
901+ cause : describeUpdateErrorCause ( error . cause ) ,
834902 operation : error . operation ,
835903 } ) ;
836904 } ) ;
@@ -861,6 +929,7 @@ export const make = Effect.gen(function* () {
861929 const error = new DesktopUpdateEventHandlingError ( { event : "download-progress" , cause } ) ;
862930 return logUpdaterWarning ( error . message , {
863931 errorTag : error . _tag ,
932+ cause : describeUpdateErrorCause ( error . cause ) ,
864933 event : error . event ,
865934 } ) ;
866935 } ) ,
@@ -885,6 +954,7 @@ export const make = Effect.gen(function* () {
885954 const error = new DesktopUpdateEventHandlingError ( { event : "update-downloaded" , cause } ) ;
886955 return logUpdaterWarning ( error . message , {
887956 errorTag : error . _tag ,
957+ cause : describeUpdateErrorCause ( error . cause ) ,
888958 event : error . event ,
889959 } ) ;
890960 } ) ,
0 commit comments