Skip to content

Commit d43240c

Browse files
fix(keybindings): thread jumps no longer overlap model picker jumps
mod+1 through mod+9 were bound to both thread.jump.X (when: isDesktop) and modelPicker.jump.X (when: modelPickerOpen && isDesktop), overlapping whenever the model picker was open on desktop. Thread jumps are now when: "!modelPickerOpen && isDesktop", so the two sets are disjoint by condition, not just by rule order. Implemented With: Muse Spark 1.3 Contributor on Opencode through T3 Code
1 parent 35be904 commit d43240c

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎docs/user/keybindings.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ the keyboard. `isWeb` is true in a browser tab. `isDesktop` is true in the
9090
desktop app. Unknown keys evaluate to `false`.
9191

9292
`mod+1` through `mod+9` jump to the first nine threads, and to models while the
93-
model picker is open. Those defaults use `isDesktop` so they do not steal the
93+
model picker is open. The thread jumps do not run while the model picker is open.
94+
Those defaults use `isDesktop` so they do not steal the
9495
browser's tab-switch shortcuts. Remove that condition in Settings if you want
9596
the same jumps in a browser.
9697

‎packages/shared/src/keybindings.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export const DEFAULT_KEYBINDINGS: ReadonlyArray<KeybindingRule> = [
6969
...THREAD_JUMP_KEYBINDING_COMMANDS.map((command, index) => ({
7070
key: `mod+${index + 1}`,
7171
command,
72-
when: "isDesktop",
72+
when: "!modelPickerOpen && isDesktop",
7373
})),
7474
...MODEL_PICKER_JUMP_KEYBINDING_COMMANDS.map((command, index) => ({
7575
key: `mod+${index + 1}`,

0 commit comments

Comments
 (0)